CI on GitHub Actions using a patched haskell-ci generated workflow #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is now ready. Please have a look at the supplied DEVELOPER.md for the explanation of the philosophy of this CI: It uses the workflow generated by
This PR should ideally squashed, but after merging #188 (so that #188's commits do not get squashed into the GHA specific stuff). |
|
I think I will just start with this one :). Can you rebase this first? I think it would be good if the PR also didn't have the extra diff from #188, even if I do squash it, for anyone reading the PR after. |
|
I rebased it onto current |
andreasabel
added a commit
to andreasabel/happy
that referenced
this pull request
Jul 14, 2021
Get CI on GitHub Actions via a patched workflow generated by haskell-ci. - DEVELOPER.md explains how to regenerate the CI, e.g. in case of new GHCs. - .github/haskell-ci.patch modifies the generated workflow by: * Setting flag 'bootstrap' to False in calls to cabal. * Installing happy instead of just building it. * Setting HAPPY and HC for running the tests. - tests/Makefile has been modified to not overwrite already set HAPPY and HC variables. This is needed to locate these executables correctly. - cabal.haskell-ci contains configuration for running haskell-ci: It removes constraints on packages containers, mtl and transformers. Otherwise, these will be constrained to the GHC-shipped versions, which isn't compatible with happy for all GHC versions. The logic behind this CI setup is identical to haskell/alex#189
andreasabel
added a commit
to andreasabel/happy
that referenced
this pull request
Jul 14, 2021
Get CI on GitHub Actions via a patched workflow generated by haskell-ci. - DEVELOPER.md explains how to regenerate the CI, e.g. in case of new GHCs. - .github/haskell-ci.patch modifies the generated workflow by: * Setting flag 'bootstrap' to False in calls to cabal. * Installing happy instead of just building it. * Setting HAPPY and HC for running the tests. - tests/Makefile has been modified to not overwrite already set HAPPY and HC variables. This is needed to locate these executables correctly. - cabal.haskell-ci contains configuration for running haskell-ci: It removes constraints on packages containers, mtl and transformers. Otherwise, these will be constrained to the GHC-shipped versions, which isn't compatible with happy for all GHC versions. The logic behind this CI setup is identical to haskell/alex#189 [fixes haskell#189] [fixes haskell#193]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, first successful run at https://github.com/andreasabel/alex/runs/2829343149?check_suite_focus=true
Rests on/includes PR #188.