Split BookendedAbsSyn out from AbsSyn
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BookendedAbsSyn` wraps it to separate the information needed by the middle parts of happy from the header and footer which are just added back at the end. The code looks nicer to me now, with fewer wildcard and @-patterns, therefore I conclude that this is makes the data structures more natural for what we are doing.
int-index
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BookendedAbsSynwraps it to separate the information needed by themiddle parts of happy from the header and footer which are just added
back at the end.
The code looks nicer to me now, with fewer wildcard and @-patterns,
therefore I conclude that this is makes the data structures more natural
for what we are doing.