-X/--value doesn't work for 'roi' command

[aragaer]

My default currency is quite volatile and I prefer reports in some other, somewhat more stable currency. Let's say I want to track some investment in commodity A while getting report in currency B (here 1/B is the volatile default currency).

P 2020-12-01 A 50
P 2020-12-01 B 100

2020-12-01 * buy A
 assets  10 A @ 50
 cash

P 2020-12-10 A 55
P 2020-12-10 B 125

2020-12-10 * reevaluate
 assets  -10 A @ 50
 assets  10 A @ 55
 equity:unrealized gains

I want to see that my investment actually went down -- It was 5B and now it's 4.4B. But I can't do that since hledger roi ignores the -X or --value flag (but it is in the documentation):

$ hledger -f /tmp/hl.journal roi --inv "assets cur:A" --pnl "unrealized gains" -X B
+---++------------+------------++---------------+----------+-------------+-----++----------+----------+
|   ||      Begin |        End || Value (begin) | Cashflow | Value (end) | PnL ||      IRR |      TWR |
+===++============+============++===============+==========+=============+=====++==========+==========+
| 1 || 2020-12-01 | 2020-12-10 ||             0 |      500 |         550 |  50 || 3142.15% | 3142.15% |
+---++------------+------------++---------------+----------+-------------+-----++----------+----------+

[simonmichael]

I agree that we should enhance roi to support this, or adjust the command line help so it doesn't advertise the valuation flags.

[aragaer]

I tried to implement this. It works but I don't feel certain enough to create a pull request yet.

[simonmichael]

This should be fixed in master by #1454, perhaps you can confirm and close this when you get a chance @aragaer.

[aragaer]

Well... yeah. It's definitely worth seeing numbers so precise. Something's off with amount formatting - I'm seeing about 250 digits after the decimal point. Otherwise it looks good.

[simonmichael]

Ouch. :-) A small repro would be great.

[aragaer]

P 2020-12-01 $ 76.20
P 2021-01-01 $ 73.88

2020-12-02 invest
 assets:investment  10000
 assets

2021-01-02 get profit
 assets:investment  =11000
 income:investment

$ stack exec -- hledger -f /tmp/roi.journal roi --inv assets:investment --pnl income:investment
+---++------------+------------++---------------+----------+-------------+------++---------+---------+
|   ||      Begin |        End || Value (begin) | Cashflow | Value (end) |  PnL ||     IRR |     TWR |
+===++============+============++===============+==========+=============+======++=========+=========+
| 1 || 2020-12-02 | 2021-01-02 ||             0 |    10000 |       11000 | 1000 || 196.58% | 196.58% |
+---++------------+------------++---------------+----------+-------------+------++---------+---------+
$ stack exec -- hledger -f /tmp/roi.journal roi --inv assets:investment --pnl income:investment -X '$'
+---++------------+------------++---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++---------+---------+
|   ||      Begin |        End || Value (begin) |                                                                                                                                                                                                                                                        Cashflow |                                                                                                                                                                                                                                                      Value (end) |                                                                                                                                                                                                                                                             PnL ||     IRR |     TWR |
+===++============+============++===============+=================================================================================================================================================================================================================================================================+==================================================================================================================================================================================================================================================================+=================================================================================================================================================================================================================================================================++=========+=========+
| 1 || 2020-12-02 | 2021-01-02 ||             0 | 135.35462912831618841364374661613427179209528965890633459664320519761775852734163508391987005955603681645912290200324851109907958852192744991878722252301028695181375203031943692474282620465619924201407688142934488359501894964807796426637791012452625879805 | 148.890092041147807255008121277747698971304818624796968056307525717379534380075798592311857065511640498105035192203573362208987547374120194910665944775311315646995127233351380617217108825121819166215484569572279371954520844612885760693015701136978884677855 | 13.535462912831618841364374661613427179209528965890633459664320519761775852734163508391987005955603681645912290200324851109907958852192744991878722252301028695181375203031943692474282620465619924201407688142934488359501894964807796426637791012452625879805 || 196.58% | 196.58% |
+---++------------+------------++---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++---------+---------+

[adept]

I did the same mistake just now :)

[simonmichael]

Should be fixed now by adept's #1460, @aragaer.

[aragaer]

Checked it, looks good.