Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account display order can be wrong when accounts are declared in multiple files #1909

Closed
simonmichael opened this issue Aug 4, 2022 · 1 comment · Fixed by #1917
Closed

account display order can be wrong when accounts are declared in multiple files #1909

simonmichael opened this issue Aug 4, 2022 · 1 comment · Fixed by #1917
Assignees
@simonmichael
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. journal The journal file format, and its features.

Comments

@simonmichael
Copy link
Owner

simonmichael commented Aug 4, 2022 •
edited
Loading

The order of account directives is tracked during parsing, but restarts from 1 in each file, instead of being a total order across all files.

It means that if you have account directives in multiple files, those accounts tend to be displayed interleaved, instead of in the order you would expect (first the accounts declared in first file, then the accounts declared in second file).
@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. journal The journal file format, and its features. labels Aug 4, 2022
simonmichael added a commit that referenced this issue Aug 5, 2022
@simonmichael
fix: don't reverse account display order with include files (#1909)
b46aa13
@simonmichael
Copy link
Owner Author

simonmichael commented Aug 12, 2022 •
edited
Loading

Update: this still has problems; I have some new tests and fixes in progress.

@simonmichael simonmichael reopened this Aug 12, 2022
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
lib: save account directive positions, for troubleshooting (#1909)
91e8914
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
imp: at --debug 5, log account declarations info while parsing (#1909)
296d7ca
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
imp: accounts: at --debug 2, show account declaration positions (#1909)
c676d24
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
dev: tests for multi-file account display order (#1909)
b280a5c
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
fix: fix multi-file account display order; improve file read logging (#…
21867d4 
…1909)
@simonmichael simonmichael mentioned this issue Aug 14, 2022
Merged
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
fix: fix multi-file account display order; improve file read logging (#…
49b4ea9 
…1909)
simonmichael added a commit that referenced this issue Aug 14, 2022
@simonmichael
imp: accounts: --declarations shows that info, not --debug (#1909)
cd9bb07
@simonmichael simonmichael self-assigned this Aug 15, 2022
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
lib: save account directive positions, for troubleshooting (#1909)
3d6e363
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
imp: at --debug 5, log account declarations info while parsing (#1909)
07e3dca
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
imp: accounts: at --debug 2, show account declaration positions (#1909)
035f2ac
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
dev: tests for multi-file account display order (#1909)
4be4525
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
fix: fix multi-file account display order; improve file read logging (#…
1f08a8a 
…1909)
simonmichael added a commit that referenced this issue Aug 16, 2022
@simonmichael
imp: accounts: --declarations shows that info, not --debug (#1909)
8ec31b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonmichael simonmichael

Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. journal The journal file format, and its features.
Projects
No open projects
2022: hledger 1.27 (Sep)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix multi-file account display order (#1909) simonmichael/hledger
1 participant
@simonmichael