Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi-file account display order (#1909) #1917

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Conversation

simonmichael
Copy link
Owner

@simonmichael simonmichael commented Aug 14, 2022

This PR fixes #1909 (by renumbering account directives after merging or finalising Journals), and adds some useful debug logging (at levels 2, 5 and 6) of file reading/including and account declaration order.

  • lib: save account directive positions, for troubleshooting (1909)
  • imp: at --debug 5, log account declarations info while parsing (1909)
  • imp: accounts: at --debug 2, show account declaration positions (1909)
  • dev: tests for multi-file account display order (1909)
  • fix: fix multi-file account display order; improve file read logging (1909)
  • dev: journalFilePath, include: show (unknown) instead of nothing
  • dev: lib: hlint improvements
  • imp: add a missing space after colon in some debug output

@ghost
Copy link

ghost commented Aug 14, 2022

Review on Crocodile

@simonmichael simonmichael changed the title 1909 display order fix multi-file account display order (#1909) Aug 14, 2022
@simonmichael simonmichael added journal The journal file format, and its features. balance accounts labels Aug 14, 2022
@simonmichael
Copy link
Owner Author

simonmichael commented Aug 14, 2022

The --debug=2 addition is slightly unorthodox: it affects the account command's standard output. Perhaps it should be a new user flag (--declarations ?), instead.

@simonmichael
Copy link
Owner Author

Added account --declarations flag.

@simonmichael simonmichael self-assigned this Aug 15, 2022
@simonmichael simonmichael merged commit 101e2f7 into master Aug 16, 2022
@simonmichael simonmichael deleted the 1909-display-order branch August 16, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts balance journal The journal file format, and its features.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

account display order can be wrong when accounts are declared in multiple files
1 participant