Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with base64 >= 1 #2166

Closed
d5ng4i opened this issue Feb 9, 2024 · 1 comment
Closed

Fails to build with base64 >= 1 #2166

d5ng4i opened this issue Feb 9, 2024 · 1 comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. impact3 Affects just a few users. packaging Dependencies, version constraints, packaging.. severity3 New user experience or installability bug. A potential user could fail to get started.

Comments

@d5ng4i
Copy link

d5ng4i commented Feb 9, 2024

Building with cabal, which resolves base64 to 1.0, fails.

We either need to pin base64 <1 in hledger-web or need to update the code.

cabal build all
Hledger/Web/Widget/AddForm.hs:189:7: error:
    • Couldn't match type ‘base64-1.0:Data.Base64.Types.Internal.Base64
                             'base64-1.0:Data.Base64.Types.Internal.StdPadded Text’
                     with ‘Text’
      Expected: Text -> Text
        Actual: Text
                -> base64-1.0:Data.Base64.Types.Internal.Base64
                     'base64-1.0:Data.Base64.Types.Internal.StdPadded Text
    • In the second argument of ‘(.)’, namely ‘b64wrap’
      In the second argument of ‘(.)’, namely ‘(<> "}") . b64wrap’
      In the first argument of ‘map’, namely
        ‘(("{\"value\":" <>) . (<> "}") . b64wrap)’
    |
189 |       b64wrap
    |       ^^^^^^^

For maintainers:

  • severity3
  • impact2

Update:

For now, we (alpine) have pinned base64 <1 here. I believe other distributions building hledger with cabal would be facing the same.

@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. packaging Dependencies, version constraints, packaging.. severity3 New user experience or installability bug. A potential user could fail to get started. impact3 Affects just a few users. labels Feb 9, 2024
@simonmichael
Copy link
Owner

Thanks for the report. I have revised hledger-web-1.32.3 on hackage and pushed a fix to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. impact3 Affects just a few users. packaging Dependencies, version constraints, packaging.. severity3 New user experience or installability bug. A potential user could fail to get started.
Projects
None yet
Development

No branches or pull requests

2 participants