Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newlines in CSV data aren't handled right #841

Closed
simonmichael opened this issue Jul 16, 2018 · 0 comments
Closed

newlines in CSV data aren't handled right #841

simonmichael opened this issue Jul 16, 2018 · 0 comments
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. csv The csv file format, csv output format, or generally CSV-related.

Comments

@simonmichael
Copy link
Owner

simonmichael commented Jul 16, 2018 •
edited

Our CSV parser does allow newlines in data if the field is double-quoted, as can happen eg in Coinbase's notes field, but assigning this to a transaction field like description will produce a malformed journal entry. It should probably convert multi-line values to one line.
@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. csv The csv file format, csv output format, or generally CSV-related. easy? good-first-issue If you're a new contributor, this might be a good one for you. labels Jul 16, 2018
@simonmichael simonmichael added the hacktoberfest Come on you merry Hacktobers, I dare you to fix something label Oct 14, 2018
@simonmichael simonmichael removed hacktoberfest Come on you merry Hacktobers, I dare you to fix something labels Nov 11, 2018
@adept adept mentioned this issue Oct 12, 2019
Merged
adept added a commit to adept/hledger that referenced this issue Nov 5, 2019
@adept
test: csv file with multiline description (simonmichael#841, simonmic…
725bee0 
…hael#416)
@simonmichael simonmichael removed easy? good-first-issue If you're a new contributor, this might be a good one for you. labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. csv The csv file format, csv output format, or generally CSV-related.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonmichael