New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very simple plugging in budget as builtin #620

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ony
Collaborator

ony commented Oct 5, 2017

Move hledger-budget to be part of buil-in commands.

ony added some commits Oct 1, 2017

bin: budget: factor out bits for reports flags
With these bucketsByOpts/offsetByOpts/applyModifierTxns/budgetByOpts it
should be easier to replace sub-command "budget" with flags generic or
injected in reporting commands.

@ony ony requested a review from simonmichael Oct 5, 2017

@ony ony added the in progress label Oct 5, 2017

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Oct 6, 2017

Owner

Nice, @ony. I am travelling and haven't been able to spend more time with this yet. Are there docs yet ? I can merge this when it comes with docs clear enough for a hledger newcomer and when two people say "I'm using this and it's useful".

Owner

simonmichael commented Oct 6, 2017

Nice, @ony. I am travelling and haven't been able to spend more time with this yet. Are there docs yet ? I can merge this when it comes with docs clear enough for a hledger newcomer and when two people say "I'm using this and it's useful".

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Dec 30, 2017

Owner

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

Owner

simonmichael commented Dec 30, 2017

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Mar 12, 2018

Owner

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

I'll do that tomorrow, unless you object.

Owner

simonmichael commented Mar 12, 2018

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

I'll do that tomorrow, unless you object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment