Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very simple plugging in budget as builtin #620

Closed
wants to merge 3 commits into from

Conversation

ony
Copy link
Collaborator

@ony ony commented Oct 5, 2017

Move hledger-budget to be part of buil-in commands.

With these bucketsByOpts/offsetByOpts/applyModifierTxns/budgetByOpts it
should be easier to replace sub-command "budget" with flags generic or
injected in reporting commands.
@simonmichael
Copy link
Owner

Nice, @ony. I am travelling and haven't been able to spend more time with this yet. Are there docs yet ? I can merge this when it comes with docs clear enough for a hledger newcomer and when two people say "I'm using this and it's useful".

@simonmichael simonmichael added budget The balance command's --budget report A-WISH Some kind of improvement request, hare-brained proposal, or plea. labels Nov 17, 2017
@simonmichael
Copy link
Owner

@simonmichael
Copy link
Owner

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

@simonmichael simonmichael added the needs:discussion To unblock: needs more discussion/review/exploration label Dec 30, 2017
@simonmichael
Copy link
Owner

What about this one @ony.. do we close it and drop the hledger-budget addon, since it is now pretty much integrated ?

I'll do that tomorrow, unless you object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. budget The balance command's --budget report needs:discussion To unblock: needs more discussion/review/exploration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants