Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets only in iD #27

Closed
70 of 73 tasks
simonpoole opened this issue Aug 22, 2017 · 15 comments
Closed
70 of 73 tasks

Presets only in iD #27

simonpoole opened this issue Aug 22, 2017 · 15 comments

Comments

@simonpoole
Copy link
Owner

simonpoole commented Aug 22, 2017

Presets present only in iD, ordered by count in OSM database, bold == count less than 1'000, only for amenity, shop, man_made, highway, waterway, railway, historic, tourism, emergency, leisure, aeroway (none missing), aerialway (none missing), natural (none missing), landuse, office and craft. This only takes "primary" keys in to account, further differing attributes are ignored for now.

Note: this is not a diff, there are presets missing in iD that are present here (but not as many).

Stroked through values are deprecated in iD and should likely be so here to.

amenity

  • amenity=swimming_pool ignored
  • amenity=public_bookcase
  • amenity=dojo
  • amenity=boat_rental
  • amenity=animal_shelter
  • amenity=public_bath
  • amenity=register_office ignored
  • amenity=animal_boarding
  • amenity=crematorium
  • amenity=love_hotel
  • amenity=waste_transfer_station
  • amenity=coworking_space iD has replaced this with office=coworking which is however lower use and contrary to the current consensus, ignored
  • amenity=animal_breeding
  • amenity=monastery
  • amenity=planetarium
  • amenity=scrapyard iD replaced this recently with industrial=scrap_yard (exists as value in this preset) based on a bogus wiki page
  • amenity=car_pooling

shop

  • shop=vacant ignored
  • shop=massage
  • shop=second_hand
  • shop=trade
  • shop=fashion added as deprecated
  • shop=charity
  • shop=craft this is very confusingly named
  • shop=gas
  • shop=carpet
  • shop=bathroom_furnishing
  • shop=money_lender
  • shop=fishmonger ignored
  • shop=chocolate
  • shop=storage_rental
  • shop=herbalist
  • shop=radiotechnics
  • shop=e-cigarette
  • shop=scuba_diving
  • shop=leather
  • shop=tiles
  • shop=religion
  • shop=nutrition_supplements
  • shop=wholesale
  • shop=appliance this would seem to have an odd neither deprecated nor documented state
  • shop=weapons
  • shop=agrarian
  • shop=furnace added as deprecated, use shop=fireplace instead
  • shop=window_blind
  • shop=pyrotechnics
  • shop=anime
  • shop=water_sports no wiki entry
  • shop=candles

man_made

  • man_made=petroleum_well
  • man_made=mast
  • man_made=pumping_station

highway

  • highway=corridor

waterway

  • waterway=sanitary_dump_station
  • waterway=water_point

railway

  • railway=derail

historic

  • historic=tomb

tourism

  • tourism=gallery
  • tourism=aquarium

emergency

  • emergency=life_ring

leisure

  • leisure=resort
  • leisure=dance
  • leisure=adult_gaming_centre
  • leisure=outdoor_seating
  • leisure=bowling_alley
  • leisure=amusement_arcade
  • leisure=hackerspace

landuse

  • landuse=churchyard
  • landuse=harbour

office

  • office=coworking use amenity=coworking_space, ignored

craft

  • craft=electronics_repair changed craft=electronics to this
  • craft=sculpter this is a typo in the preset in iD should be sculptor, ignored

Present in both but deprecated in iD

  • amenity=nursing_home deprecated here too
@bhousel
Copy link

bhousel commented Aug 22, 2017

Hey @simonpoole! You may want to filter out the presets where "searchable": false. These are ones that we don't let people actually pick in iD, but we do recognize so we can render legacy data correctly.

There are a bunch in this list - off the top of my head shop=fishmonger, shop=vacant are like this.

We also name the preset definition file with an underscore like _fishmonger.json or _vacant.json, as a naming convention to know that it's not a searchable preset.

@simonpoole
Copy link
Owner Author

simonpoole commented Aug 22, 2017

Hi @bhousel this is/was just a raw list semi-manually generated from the taginfo project stats and needs to be pruned down to remove deprecated stuff and so on. Or with other words: I'm not saying that all of the preset -should- actually be included elsewhere (PS I support a deprecated attribute that does much the same http://vespucci.io/tutorials/presets/#extensions) .

Note on the side: went out survey for a bit just before and would have actually needed 3-4 shops from the list :-).

@bhousel
Copy link

bhousel commented Aug 22, 2017

Hi @bhousel this is/was just a raw list semi-manually generated from the taginfo project stats and needs to be pruned down to remove deprecated stuff and so on

Oh that makes sense. I wonder if iD should maybe not send the deprecated presets to taginfo in the project file? I wouldn't want people to draw a wrong conclusion about how we use the tag, e.g. "can't deprecate shop=fishmonger because iD still uses it."

cc @joto ?

@joto
Copy link

joto commented Aug 22, 2017

@bhousel I have thought about that, too. I think it could make sense to "flag" tags in some way to make this clear. But currently there is no way of doing this. A workaround could be to have two lists, one for the used tags, one for the deprecated ones. I'd be happy for more ideas how the projects feature in taginfo can be improved, I haven't done much with it lately, because I don't see much adoption really, although I still think it is useful (as this issue shows).

@simonpoole
Copy link
Owner Author

simonpoole commented Aug 22, 2017

@joto not sure if it is worth it, as really only the editors are likely to even have the notion of "deprecated" (well AFAIK only iD and vespucci) and the actual numbers, see above are small.

Naturally it would be really nice if the comparison could be done automatically for a set of "primary keys" (open can of worms). Doesn't need a UI as such.

@joto
Copy link

joto commented Aug 22, 2017

@simonpoole If I remember correctly Nominatim also supports some tags that are deprecated. The meaning is slightly different there: "You should really not use this tag, but we understand it anyway." Or you want to say something like: I support key=*, but not key=special_value. There is no way to express this. So there are more reasons to have some some "flags" on tags. I am just not sure how to do this without making everything too complicated.

simonpoole added a commit that referenced this issue Aug 23, 2017
@matkoniecz
Copy link
Contributor

amenity=register_office should be deprecated in iD see the wiki

Is the need for deprecation reported somewhere? Because according to openstreetmap/iD#3245 it already got deprecated one year ago.

@matkoniecz
Copy link
Contributor

amenity=scrapyard

now deprecated in iD - see openstreetmap/iD@9c5a79a

@matkoniecz
Copy link
Contributor

amenity=planetarium

Would be OK to make PR that would add this, without an icon?

@simonpoole
Copy link
Owner Author

simonpoole commented Nov 4, 2017

@matkoniecz planetarium: sure, but the actual work is creating an icon.

WRT to scrapyard, unluckily the iD change openstreetmap/iD@9c5a79a doesn't actually make any sense see https://taginfo.openstreetmap.org/search?q=scrapyard#values and is another of the unilateral "trying to get my way" changes (people manipulating documentation so that their requests seem legit) that we see so often in the iD presets (a publicly accessible scrapyard may have its landuse mapped as landuse=industrial, industrial=scrapyard, but that doesn't imply that something just mapped as landuse it is a facility you can actually use). .

@matkoniecz
Copy link
Contributor

the actual work is creating an icon

I know that it is 98% of work but I was unsure whatever PR with other 2% of work would be considered as useful or not.

@bhousel
Copy link

bhousel commented Nov 4, 2017

WRT to scrapyard, unluckily the iD change openstreetmap/iD@9c5a79a doesn't actually make any sense see https://taginfo.openstreetmap.org/search?q=scrapyard#values and is another of the unilateral "trying to get my way" changes that we see so often in the iD presets (a publicly accessible scrapyard may have its landuse mapped as landuse=industrial, industrial=scrapyard, but that doesn't imply that something just mapped as landuse it is a facility you can actually use). .

I made this change for a few reasons

  • The wiki has some strong language that it should be tagged this way, and not as an amenity.
  • It has around 200 uses worldwide, which is another way of saying - nobody cares.

Please be nice. I'm not "trying to get my way", I'm just trying to close issues.

I agree that tagging POI style features as landuse=* is stupid. That ship has sailed and OSM has lots of them now.

@simonpoole
Copy link
Owner Author

simonpoole commented Nov 4, 2017

@bhousel " "trying to get my way" was intended for the people manipulating thing so they seem legit, in this case the creator and sole editor of the industrial=scrap_yard page. PS: I changed the text to make it clear.

There is a reason that historically editor presets have had a high hysteresis

@yvecai
Copy link

yvecai commented Nov 4, 2017

"I agree that tagging POI style features as landuse=* is stupid. That ship has sailed and OSM has lots of them now."
OSM has plenty of both, and the ship sails well enough with that.

@simonpoole
Copy link
Owner Author

With exception of the landuse tags this has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants