-
Notifications
You must be signed in to change notification settings - Fork 25
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presets only in iD #27
Comments
Hey @simonpoole! You may want to filter out the presets where There are a bunch in this list - off the top of my head We also name the preset definition file with an underscore like |
Hi @bhousel this is/was just a raw list semi-manually generated from the taginfo project stats and needs to be pruned down to remove deprecated stuff and so on. Or with other words: I'm not saying that all of the preset -should- actually be included elsewhere (PS I support a deprecated attribute that does much the same http://vespucci.io/tutorials/presets/#extensions) . Note on the side: went out survey for a bit just before and would have actually needed 3-4 shops from the list :-). |
Oh that makes sense. I wonder if iD should maybe not send the deprecated presets to taginfo in the project file? I wouldn't want people to draw a wrong conclusion about how we use the tag, e.g. "can't deprecate cc @joto ? |
@bhousel I have thought about that, too. I think it could make sense to "flag" tags in some way to make this clear. But currently there is no way of doing this. A workaround could be to have two lists, one for the used tags, one for the deprecated ones. I'd be happy for more ideas how the projects feature in taginfo can be improved, I haven't done much with it lately, because I don't see much adoption really, although I still think it is useful (as this issue shows). |
@joto not sure if it is worth it, as really only the editors are likely to even have the notion of "deprecated" (well AFAIK only iD and vespucci) and the actual numbers, see above are small. Naturally it would be really nice if the comparison could be done automatically for a set of "primary keys" (open can of worms). Doesn't need a UI as such. |
@simonpoole If I remember correctly Nominatim also supports some tags that are deprecated. The meaning is slightly different there: "You should really not use this tag, but we understand it anyway." Or you want to say something like: I support |
Is the need for deprecation reported somewhere? Because according to openstreetmap/iD#3245 it already got deprecated one year ago. |
now deprecated in iD - see openstreetmap/iD@9c5a79a |
Would be OK to make PR that would add this, without an icon? |
@matkoniecz planetarium: sure, but the actual work is creating an icon. WRT to scrapyard, unluckily the iD change openstreetmap/iD@9c5a79a doesn't actually make any sense see https://taginfo.openstreetmap.org/search?q=scrapyard#values and is another of the unilateral "trying to get my way" changes (people manipulating documentation so that their requests seem legit) that we see so often in the iD presets (a publicly accessible scrapyard may have its landuse mapped as landuse=industrial, industrial=scrapyard, but that doesn't imply that something just mapped as landuse it is a facility you can actually use). . |
I know that it is 98% of work but I was unsure whatever PR with other 2% of work would be considered as useful or not. |
I made this change for a few reasons
Please be nice. I'm not "trying to get my way", I'm just trying to close issues. I agree that tagging POI style features as |
@bhousel " "trying to get my way" was intended for the people manipulating thing so they seem legit, in this case the creator and sole editor of the industrial=scrap_yard page. PS: I changed the text to make it clear. There is a reason that historically editor presets have had a high hysteresis |
"I agree that tagging POI style features as landuse=* is stupid. That ship has sailed and OSM has lots of them now." |
With exception of the landuse tags this has been done. |
Presets present only in iD, ordered by count in OSM database, bold == count less than 1'000, only for amenity, shop, man_made, highway, waterway, railway, historic, tourism, emergency, leisure, aeroway (none missing), aerialway (none missing), natural (none missing), landuse, office and craft. This only takes "primary" keys in to account, further differing attributes are ignored for now.
Note: this is not a diff, there are presets missing in iD that are present here (but not as many).
Stroked through values are deprecated in iD and should likely be so here to.
amenity
amenity=swimming_poolignoredamenity=register_officeignoredamenity=coworking_spaceiD has replaced this with office=coworking which is however lower use and contrary to the current consensus, ignoredamenity=scrapyardiD replaced this recently with industrial=scrap_yard (exists as value in this preset) based on a bogus wiki pageshop
shop=vacantignoredshop=fishmongerignoredman_made
highway
waterway
railway
historic
tourism
emergency
leisure
landuse
office
craft
Present in both but deprecated in iD
The text was updated successfully, but these errors were encountered: