Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on new camb version #97

Closed
itrharrison opened this issue Feb 24, 2023 · 2 comments · Fixed by #98
Closed

Tests fail on new camb version #97

itrharrison opened this issue Feb 24, 2023 · 2 comments · Fixed by #98
Assignees
Labels
bug Something isn't working tests Improvements to tests

Comments

@itrharrison
Copy link
Collaborator

Two tests against precomputed likelihood values now fail see here, I'm pretty sure due to the bump in camb version to v1.4.

e.g.

FAILED test_clusters.py::test_clusters_loglike - assert array([False])
 +  where array([False]) = (array([-854.8981993]), -855.0)

I can just update the test against the new precomputed likelihood values, or change the tolerance on the isclose.

@itrharrison itrharrison added bug Something isn't working tests Improvements to tests labels Feb 24, 2023
@itrharrison itrharrison self-assigned this Feb 24, 2023
@itrharrison
Copy link
Collaborator Author

itrharrison commented Feb 24, 2023

I can confirm that putting camb<1.4 in the requirements.txt is another option to make the tests pass. Hidde points out this is likely due to the derfault neutrino spec changing.

@cmbant
Copy link
Collaborator

cmbant commented Feb 24, 2023

Looks like a small change, similar to other likelihood test tweaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improvements to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants