Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bias models as cobaya theory #33

Closed
itrharrison opened this issue Oct 18, 2021 · 1 comment · Fixed by #41
Closed

Implement bias models as cobaya theory #33

itrharrison opened this issue Oct 18, 2021 · 1 comment · Fixed by #41
Assignees
Labels
enhancement New feature or request

Comments

@itrharrison
Copy link
Collaborator

itrharrison commented Oct 18, 2021

After chatting with @Pablo-Lemos on Friday, we felt it could be a good idea to implement galaxy bias models at the level of a cobaya theory class, in order that the parameters can be seen by multiple likelihoods (and the code only needs to be implemented or hooked into once etc).

I would start this at either end of the complexity scale:

Does this seem sensible to others?

@itrharrison itrharrison added the enhancement New feature or request label Oct 18, 2021
@itrharrison itrharrison self-assigned this Oct 18, 2021
@timothydmorton
Copy link
Collaborator

I think this is a good idea. My recommendation is to do both, but to start with the simpler model. This way you can get everything working with breaking out that part of the theory calculation from the XcorrLikelihood, as well as work out all the kinks of creating a new Theory with the simple case. After that has been done, it should be easier to implement velocileptors as a Theory, and that work can be separate from the adjustments needed to the user likelihoods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants