Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Datasette.app breaks the virtual environment, prevents startup #89

Closed
simonw opened this issue Sep 10, 2021 · 1 comment
Closed
Labels
bug Something isn't working electron-wrapper Features that go in the Node.js/Electron code

Comments

@simonw
Copy link
Owner

simonw commented Sep 10, 2021

I used a temporary Datasette.app and then deleted it. In doing so it created a venv which then broke with this error:

datasette-app % /Users/simon/.datasette-app/venv/bin/pip\
  install \
  "datasette>=0.59a2" \
  "datasette-app-support>=0.7" \
  "datasette-vega>=0.6.2" \
  "datasette-cluster-map>=0.17.1" \
  "datasette-pretty-json>=0.2.1" \
  "datasette-edit-schema>=0.4" \
  "datasette-configure-fts>=1.1"
zsh: /Users/simon/.datasette-app/venv/bin/pip: bad interpreter: /Users/simon/.datasette-app/venv/bin/python3.9: no such file or directory

The app has no error handling around the pip install call so it just hung on the loading screen.

@simonw simonw added bug Something isn't working electron-wrapper Features that go in the Node.js/Electron code labels Sep 10, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

I need to catch this error and, if it occurs, delete and re-create the virtual environment.

(Another reason that I should persist details of the plugins the user had already installed so I can help them recover from this, refs #72)

@simonw simonw closed this as completed in 577a7f9 Sep 10, 2021
simonw added a commit that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electron-wrapper Features that go in the Node.js/Electron code
Projects
None yet
Development

No branches or pull requests

1 participant