Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better plugin installation interface (plugin directory) #74

Closed
6 tasks done
simonw opened this issue Sep 8, 2021 · 10 comments
Closed
6 tasks done

Better plugin installation interface (plugin directory) #74

simonw opened this issue Sep 8, 2021 · 10 comments

Comments

@simonw
Copy link
Owner

simonw commented Sep 8, 2021

I punted on this in #5 - see also this suggestion from @psychemedia in #67 (comment)

  • plugins: it would be handy to be able to select a plugin to install from a list. Gephi desktop used to have a two panel view to select plugins: available and uninstalled plugins in the left hand panel, installed plugins in the right. IIRC, each list had a check box by each item: check items in left and click Install to install, check items in right and click Uninstall to uninstall.
@simonw
Copy link
Owner Author

simonw commented Sep 8, 2021

I can hit the API for https://datasette.io/content/plugins ( https://datasette.io/content/plugins.json ) to get the data. Would it be useful to filter that down to just the plugins that are known to work well with Datasette Desktop though?

I'm inclined not to do that. If a plugin doesn't work well with Datasette Desktop that's a bug in the plugin that should be fixed. Even the ones you wouldn't expect to be useful (datasette-publish-fly for example) are still useful if the documentation helps the user figure out how to run ~/.datasette-app/venv/bin/datasette.

@simonw simonw added this to the 0.2 - plugins and progress bars milestone Sep 8, 2021
@psychemedia
Copy link

Could you use something like italics to show extensions that don't work in the app?

@simonw
Copy link
Owner Author

simonw commented Sep 9, 2021

New menu item:

+        {
+          label: "Install Plugins…",
+          click() {
+            let newWindow = new BrowserWindow(windowOpts());
+            newWindow.loadFile("plugins.html");
+            configureWindow(newWindow);
+          },
+        },

@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

Here's a fun idea: what if the list of plugins you could install was a very lightly customized Datasette table? Would get search and faceting for free, and help people further understand what the tool can be used for.

Could be pre-populated in the temporary database perhaps?

Or just an in-memory plugins database which is deliberately excluded from the homepage.

simonw added a commit to simonw/datasette-app-support that referenced this issue Sep 10, 2021
simonw added a commit to simonw/datasette-app-support that referenced this issue Sep 11, 2021
simonw added a commit to simonw/datasette-app-support that referenced this issue Sep 11, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

Uninstall work will happen in #72.

@simonw simonw changed the title Better plugin installation interface (list of plugins) Better plugin installation interface (plugin directory) Sep 11, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

Each plugin should also show which version you have installed, what the latest version is and provide the option to upgrade.

The install status facet can have an extra value for upgradable.

@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

An "upgrade all" button would be good too.

This was referenced Sep 11, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

For the next release I'm going to implement "upgrade" but I won't fix "uninstall" - because uninstall requires a complex additional layer of persistence to avoid re-installing default plugins, see #101.

@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

I'm dropping the "compatible with Datasette Desktop" feature for the moment.

@simonw
Copy link
Owner Author

simonw commented Sep 11, 2021

I'm going to ship what I've got as a new datasette-app-support release and close this issue.

@simonw simonw closed this as completed in b13d8bd Sep 11, 2021
simonw added a commit that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants