Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up debug menu #94

Closed
simonw opened this issue Sep 10, 2021 · 5 comments
Closed

Tidy up debug menu #94

simonw opened this issue Sep 10, 2021 · 5 comments
Labels
developer-experience electron-wrapper Features that go in the Node.js/Electron code usability

Comments

@simonw
Copy link
Owner

simonw commented Sep 10, 2021

The debug menu is a bit of a mess already:

Debug_and_Menubar

Originally posted by @simonw in #93 (comment)

@simonw simonw added usability developer-experience electron-wrapper Features that go in the Node.js/Electron code labels Sep 10, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

I can make the "Stop Server and Copy Command" option more obvious by adding a confirmation dialog with extra details, as seen here:

datasette-app/main.js

Lines 916 to 929 in a4ede0f

{
label: "Reinstall Datasette",
click() {
dialog
.showMessageBox({
type: "warning",
message: "Delete and reinstall Datasette?",
detail:
"This will upgrade Datasette to the latest version, and remove all currently installed additional plugins.",
buttons: ["OK", "Cancel"],
})
.then(async (click) => {
if (click.response == 0) {
// Clicked OK

@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

I think "Run Server Manually".

@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

Here's the new design for that feature:

Debug_and_Menubar

@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

I'm going to group these - the server stuff can go together.

@simonw simonw closed this as completed in e3febf3 Sep 10, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 10, 2021

Menu now looks like this:
Debug_and_Menubar

simonw added a commit that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience electron-wrapper Features that go in the Node.js/Electron code usability
Projects
None yet
Development

No branches or pull requests

1 participant