OperationalError('interrupted') can 500 on row page

[simonw]

I got this on my (private) https://dogsheep.simonwillison.net/twitter/tweets/1188612004572880896 page:

[simonw]

I'm suspicious of this code:

datasette/datasette/views/table.py

Lines 1032 to 1045 in e8e0a6f

	sql = "select " + ", ".join(
	[
	"(select count(*) from {table} where {column}=:id)".format(
	table=escape_sqlite(fk["other_table"]),
	column=escape_sqlite(fk["other_column"]),
	)
	for fk in foreign_keys
	]
	)
	try:
	rows = list(await db.execute(sql, {"id": pk_values[0]}))
	except sqlite3.OperationalError:
	# Almost certainly hit the timeout
	return []

This code uses a different exception:

datasette/datasette/views/table.py

Lines 658 to 663 in e8e0a6f

	if count_sql and filtered_table_rows_count is None:
	try:
	count_rows = list(await db.execute(count_sql, from_sql_params))
	filtered_table_rows_count = count_rows[0][0]
	except QueryInterrupted:
	pass

[simonw]

Yup, swapping QueryInterrupted fixed this against my giant database.

[simonw]

I'm going to fix this without a test, because writing a test for this is a bit fiddly and it's a very minor bug. If it comes back again I'll do the work to test for it.