Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseToHSV() does not handle "1" alpha values #19

Closed
yamass opened this issue Jul 5, 2018 · 2 comments
Closed

parseToHSV() does not handle "1" alpha values #19

yamass opened this issue Jul 5, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@yamass
Copy link

yamass commented Jul 5, 2018

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

Color.parseToHSV("rgba(70,70,70,1)") returns null.

If the current behavior is a bug, please provide the steps to reproduce.

Color.parseToHSV("rgba(70,70,70,1)")

What is the expected behavior?

return the correct value.
This seems to be a regression introduced by 166ce8d

Your environment:

Pickr-version: latest master
Browser-version:  Chrome 68 beta
Operating-system:  MacOs
@simonwep simonwep added the bug Something isn't working label Jul 5, 2018
@simonwep
Copy link
Owner

simonwep commented Jul 5, 2018

Damn, I don't wanna close it by myself haha... anyway, I've fixed it!

@yamass
Copy link
Author

yamass commented Jul 5, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants