Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SIMP-5335) Wrong GitLab env var for Puppet 5 #38

Merged
merged 3 commits into from
Oct 31, 2018

Conversation

lnemsick-simp
Copy link
Contributor

  • Fix Puppet collection env variable in .gitlab-ci.yml
  • Update badges and contribution guide URL in README.md
  • Update to onyxpoint OEL boxes in acceptance tests
  • Fix incorrect use of BEAKER_PUPPET_ENVIRONMENT/puppet_environment
  • Update static assets
    • Explicitly unit test with Puppet 5.5.6
    • Make sure at least 1 Puppet 4, Puppet 5, Puppet 5 FIPS, and
      Puppet 4 OEL acceptance test is run in the acceptance
      test subset

SIMP-5335 #comment pupmod-simp-openscap
SIMP-5430 #comment pupmod-simp-openscap
SIMP-4964 #comment pupmod-simp-openscap

- Fix Puppet collection env variable in .gitlab-ci.yml
- Update badges and contribution guide URL in README.md
- Update to onyxpoint OEL boxes in acceptance tests
- Fix incorrect use of BEAKER_PUPPET_ENVIRONMENT/puppet_environment
- Update static assets
  - Explicitly unit test with Puppet 5.5.6
  - Make sure at least 1 Puppet 4, Puppet 5, Puppet 5 FIPS, and
    Puppet 4 OEL acceptance test is run in the acceptance
    test subset

SIMP-5335 #comment pupmod-simp-openscap
SIMP-5430 #comment pupmod-simp-openscap
SIMP-4964 #comment pupmod-simp-openscap
@lnemsick-simp
Copy link
Contributor Author

lnemsick-simp commented Oct 29, 2018

op-ct
op-ct previously requested changes Oct 30, 2018
.gitlab-ci.yml Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
- Remove TRUSTED_NODE_DATA=yes setting in .travis.yml files
- Set Puppet 5.5 as the lower bound in static assets
- Update gem specifications
@lnemsick-simp lnemsick-simp dismissed op-ct’s stale review October 31, 2018 16:38

Resolved identified issues

@lnemsick-simp
Copy link
Contributor Author

@trevor-vaughan trevor-vaughan merged commit 45f1dfc into simp:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants