Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font does not work in Firefox #19

Closed
ericcornelissen opened this issue Jul 23, 2019 · 3 comments
Closed

Font does not work in Firefox #19

ericcornelissen opened this issue Jul 23, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@ericcornelissen
Copy link
Contributor

As per #14 (comment) it appears that the font ligatures are not being displayed at all in Firefox 68.0 (64-bit).
@ericcornelissen ericcornelissen added the bug Something isn't working label Jul 23, 2019
@cactysman
Copy link
Contributor

cactysman commented Jul 23, 2019 •
edited
Loading

Are you viewing the test page as a local file on your PC?

I guess you are having this "problem". Your Firefox isn't allowed to load local font files without explicit permission like settings or command line flags (at least that's what you can do with Chrome).

If you open it served from a web server¹, it will display correctly:

image

¹ I like to use anywhere. Go to your directory and run npx anywhere.

@ericcornelissen
Copy link
Contributor Author

Are you viewing the test page as a local file on your PC?

That is indeed the case.

If you open it served from a web server¹, it will display correctly:

Okay, I will try that as soon as possible and report back here.

If this is indeed the case we should consider making it easy for contributors to do run such a server locally (perhaps using anywhere) so they can easily test it in Firefox (and Chrome if they changed the setting) if they so choose. Making their life's easier and preventing anyone from reporting this "bug" in the future.

@ericcornelissen ericcornelissen mentioned this issue Jul 23, 2019
Closed
@ericcornelissen
Copy link
Contributor Author

Okay, I will try that as soon as possible and report back here.

Works perfectly 😄 Very interesting, wasn't aware this was a thing.

If this is indeed the case we should consider making it easy for contributors to do run such a server locally (perhaps using anywhere) so they can easily test it in Firefox (and Chrome if they changed the setting) if they so choose. Making their life's easier and preventing anyone from reporting this "bug" in the future.

I made this anyway while I was trying to see if the suggestion fixed the bug, so I opened #23

ericcornelissen added a commit that referenced this issue Oct 7, 2019
@ericcornelissen
Run local server with test script (#23)
f57c09e 
Run local server with test script using anywhere[1]. This automatically builds the test-page and opens it for you in a local server.

Having it open in a local server prevents issues as described in #19

--

1. https://www.npmjs.com/package/anywhere
ericcornelissen added a commit that referenced this issue Oct 11, 2019
@ericcornelissen
Release new version with simple-icons v1.17.1 (#26)
468c270 
* Update status badge in README.md

* Update Simple Icons to v1.14.0 (#20)

* Update SimpleIcons dependency to v1.12.0

* Fix build error due to new `.get` API function [REVERTED]

This solution is a bit of a hack. I think the real solution needs to be 
found up-stream.

* Update SimpleIcons dependency to v1.13.0

* Update SimpleIcons dependency to v1.14.0

* Run local server with test script (#23)

Run local server with test script using anywhere. This automatically builds the test-page and opens it for you in a local server.

Having it open in a local server prevents issues as described in #19

* Update simple-icons to v1.17.1 (#24)

* Use 'slug' property in build script (#25)

* Replace usage of titleToFilename by icon.slug

* Remove utilities module as it is no longer used

* [CI] Custom script for release stage

* version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericcornelissen @cactysman