Update Simple Icons to v1.14.0 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution is a bit of a hack. I think the real solution needs to be found up-stream.
ericcornelissen
added
the
dependencies
This comment has been minimized.
This comment has been minimized.
ericcornelissen
changed the title
ericcornelissen
changed the title
ericcornelissen
added a commit
that referenced
this pull request
Oct 11, 2019
* Update status badge in README.md * Update Simple Icons to v1.14.0 (#20) * Update SimpleIcons dependency to v1.12.0 * Fix build error due to new `.get` API function [REVERTED] This solution is a bit of a hack. I think the real solution needs to be found up-stream. * Update SimpleIcons dependency to v1.13.0 * Update SimpleIcons dependency to v1.14.0 * Run local server with test script (#23) Run local server with test script using anywhere. This automatically builds the test-page and opens it for you in a local server. Having it open in a local server prevents issues as described in #19 * Update simple-icons to v1.17.1 (#24) * Use 'slug' property in build script (#25) * Replace usage of titleToFilename by icon.slug * Remove utilities module as it is no longer used * [CI] Custom script for release stage * version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates Simple Icons to the latest version. See simple-icons/simple-icons#1549 for details.
Due to a change in the API I had to implement a bit of a hack to circumvent a problem with iterating over all the icons.
I will be addressing this issue up-stream 馃憤 EDIT: see simple-icons/simple-icons#1554This has been fixed and we should remove the hack when upgrading to the next version of Simple Icons.