Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run local server with test script #23

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Run local server with test script #23

merged 1 commit into from
Oct 7, 2019

Conversation

ericcornelissen
Copy link
Contributor

Run a local server with $ npm test script using anywhere. This automatically builds the test page ($ npm run build:testpage) and opens it for you in a locally run server (I intentionally set the host to localhost).

@ericcornelissen
Run local server with test script
6cd94e7 
... using anywhere[1]. This automaically builds the testpage and opens 
it for you in a local server.

Having it open in a local server prevents issues as described in 
#19

--

1. https://www.npmjs.com/package/anywhere
@ericcornelissen ericcornelissen mentioned this pull request Jul 23, 2019
Closed
@ericcornelissen
Copy link
Contributor Author

@metaa, do you have any feedback on this?

@cactysman
Copy link
Contributor

I'm sorry for being so unresponsive, I've got a lot going on lately.

cactysman
cactysman approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@cactysman cactysman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfectly fine to me, although maybe using npx anywhere would keep the burden of updating anywhere from us? 🤔
But then again, not having to download it when attempting to test makes it a smoother overall, so that's a plus.

@ericcornelissen
Copy link
Contributor Author

ericcornelissen commented Sep 29, 2019 •
edited
Loading

This looks perfectly fine to me, although maybe using npx anywhere would keep the burden of updating anywhere from us? 🤔
But then again, not having to download it when attempting to test makes it a smoother overall, so that's a plus.

Hmm, interesting, I didn't know that is what npx did. I guess we could you use that, but in this case I don't think it adds that much value 🤔

If updating anywhere really concerns you, I don't think we have to worry about that too much since it is a dev-dependency anyway (i.e. security vulnerabilities are not as relevant). If we care about keeping the dependencies here up-to-date I think we can use a similar strategy as we have in the main repository.

@ericcornelissen ericcornelissen added the meta Issues or pull requests regarding the project or repository itself label Oct 7, 2019
@ericcornelissen ericcornelissen merged commit f57c09e into simple-icons:develop Oct 7, 2019
@ericcornelissen ericcornelissen deleted the dev-feat/simple-local-server branch October 7, 2019 06:01
ericcornelissen added a commit that referenced this pull request Oct 11, 2019
@ericcornelissen
Release new version with simple-icons v1.17.1 (#26)
468c270 
* Update status badge in README.md

* Update Simple Icons to v1.14.0 (#20)

* Update SimpleIcons dependency to v1.12.0

* Fix build error due to new `.get` API function [REVERTED]

This solution is a bit of a hack. I think the real solution needs to be 
found up-stream.

* Update SimpleIcons dependency to v1.13.0

* Update SimpleIcons dependency to v1.14.0

* Run local server with test script (#23)

Run local server with test script using anywhere. This automatically builds the test-page and opens it for you in a local server.

Having it open in a local server prevents issues as described in #19

* Update simple-icons to v1.17.1 (#24)

* Use 'slug' property in build script (#25)

* Replace usage of titleToFilename by icon.slug

* Remove utilities module as it is no longer used

* [CI] Custom script for release stage

* version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cactysman cactysman cactysman approved these changes

Assignees
No one assigned
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericcornelissen @cactysman