Request: TypeORM #10896
Comments
uncenter
added
the
vector unavailable
|
Duplicate of #8147 |
|
Hi everyone! I've read through the issue #8147 , and I noticed that you had assigned someone to add TypeORM icon before, but then closed that issue (I'm assuming, those who were assigned, could not complete the task). I wanted to ask you if I could contribute somehow and add TypeORM icon to your library? What are the requirements and what is the process? Also, I've noticed the I'm attaching an Thanks!
|
|
Okay, actually I went through the icons source in this repo, and found some requirement patterns inside the SVGs. I've taken Amazon Document DB as the reference, because it's somewhat similar graphically to the TypeORM logo. I've changed the viewBox to "0 0 24 24", simplified paths, transformed and scaled the original TypeORM SVG to fit the structure and properties of your SVGs. Now, here's the code of the resulting SVG: And here's what it looks like: Can I open a PR? Thanks! |
|
Go ahead! Note that as per our requirements that SVG isn't completely done - there needs to be only a single |
|
@uncenter I've followed your advice and also all the guidelines from Contributing to Simple Icons Here's my And that's a part of json I wanted to add to Now, I have a problem though. I've followed all the steps like forking the repo, cloning it, creating a new branch from But when I commit and try to push to a new branch I've just created with Do I have to be added as a contributor to this repo first, or am I missing something? Thanks! |
|
You need to fork this repository and then make a pull request. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request. Also, let's try to keep discussion in the open #8147 issue! (P.S. I also recommend you take a look at https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks for a guide on how to create code blocks instead of inline code like you are doing now.) |
|
@uncenter |
Brand Name
TypeORM
Website
https://typeorm.io/
Popularity Metric
https://www.similarweb.com/website/typeorm.io/
Official Resources for Icon and Color
https://raw.githubusercontent.com/typeorm/typeorm/master/resources/logo_big.png
Additional Comments
Hi!
Love your set of icons, but would like to see TypeORM as well.
You already have Prisma and Drizzle, so that's awesome, but TypeORM is the one I'm missing and would like to use to add to my tech stack portfolio.
Thanks!
The text was updated successfully, but these errors were encountered: