New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Google AdSense #4472
Updated Google AdSense #4472
Conversation
Should the gap not be 0.5dp? |
Yeah, this was prior to 0.5 being decided. I'll update this one 👌 |
Using the base-64 encoded SVG found in the website header (below), I'm seeing some minor differences in the green and yellow shapes (with your version in red in both cases):
|
@PeterShaggyNoble give that a try - I've rebuilt from the Base64 SVG, and compared against it. Unfortunately it did require 4 decimals for me to get it working, and there's still a minor difference along where the circle was. |
Managed to get it down to a precision of 3, if you want to run with it:
|
That path is showing as 23.999 x 21.249, so will see if it's fixable with a quick tweak in Illustrator. Thanks for sending across @PeterShaggyNoble. EDIT: Should be good to go now. Was able to get it to 3 decimals by changing path size to 24.001px wide 🙄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me now, @adamrusted 👍🏻 As I helped out on it, though, we'll need one of the other @simple-icons/maintainers to double check and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job! 💯
# New Icons - Aeroméxico (#4760) - Air China (#4799) - Alibaba Cloud (#4819) - Amazon Pay (#4793) - BBC (#4846) - Chainlink (#4857) - Chakra UI (#4851) - China Southern Airlines (#4837) - CountingWorks PRO (#4796) - Delta (#4844) - Emirates (#4862) - Falcon (#4841) - Jamstack (#4831) - macOS (#4867) - NASA (#4850) - Nrwl (#4859) - Okta (#4852) - OYO (#4840) - Premier League (#4753) - Redux-Saga (#4803) - Screencastify (#4806) - SFML (#4678) - Statuspal (#4823) - stylelint (#4838) - Tampermonkey (#4843) - TV Time (#4766) - Vector Logo Zone (#4842) - Vectorworks (#4764) - Zoiper (#4854) # Updated Icons - Anchor (#4880) - Google AdSense (#4472) - Google News (#4474) - Google Scholar (#4686) - Google Translate (#4584) - Opel (#4813)
Issue: Contributes to #4205
Alexa rank: N/A
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Changed source according to comment.
Rebuilt icon from source, with gap of
0.35px0.5px between colours.Unfortunately, I couldn't get this path to less than 4 decimals.