Add IBM Cloud icon #6746

asmitbm · 2021-10-18T14:58:51Z

Signed-off-by: Asmit2952 asmitbm2952002@gmail.com

**Issue: #6723 **
Alexa rank: 635

Checklist

I updated the JSON data in _data/simple-icons.json
I optimized the icon with SVGO or SVGOMG
The SVG viewbox is 0 0 24 24

Description

SVG and colors sourced from IBMs Official branding website.

Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com>

dirien

hi @asmit2952,

Unfortunatly there is a login screen. Can you maybe add the original icon as comment?

asmitbm · 2021-11-06T07:47:41Z

hi @asmit2952,

Unfortunatly there is a login screen. Can you maybe add the original icon as comment?

Are these enough? @dirien

dirien · 2021-11-07T14:28:49Z

hmm reading the special use case and misuse guide (no flat logo) i am not sure if we can use it in simple-icons. Asking @service-paradis and @ericcornelissen for help.

asmitbm · 2021-11-07T15:19:22Z

hmm reading the special use case and misuse guide (no flat logo) i am not sure if we can use it in simple-icons. Asking @service-paradis and @ericcornelissen for help.

Yup, I read that, and used gradient logo as suggested. Flat logo is not used in my PR.

dirien · 2021-11-08T07:14:43Z

@asmit2952, can you save the pic of the site, not a screenshot, add attach to this PR? or even if possible to original svg? thanks

asmitbm · 2021-11-08T07:25:59Z

@asmit2952, can you save the pic of the site, not a screenshot, add attach to this PR? or even if possible to original svg? thanks

Save the pic of the site means? Like the whole ss of the site? And original svg isn't available right on the site, you need to be IBM employee for that.

I converted the PNG image on the official site to SVG. Then optimized it with the SVGOMG Online tool.

Shall I create a trash IBM account?

dirien · 2021-11-08T07:27:56Z

@asmit2952, can you save the pic of the site, not a screenshot, add attach to this PR? or even if possible to original svg? thanks

Save the pic of the site means? Like the whole ss of the site? And original svg isn't available right on the site, you need to be IBM employee for that.

I converted the PNG image on the official site to SVG. Then optimized it with the SVGOMG Online tool.

Please add the PNG image to this PR, that will help :)

asmitbm · 2021-11-08T08:27:33Z

@asmit2952, can you save the pic of the site, not a screenshot, add attach to this PR? or even if possible to original svg? thanks

Save the pic of the site means? Like the whole ss of the site? And original svg isn't available right on the site, you need to be IBM employee for that.

I converted the PNG image on the official site to SVG. Then optimized it with the SVGOMG Online tool.

Please add the PNG image to this PR, that will help :)

Official image as seen in the above screenshot.

dirien

hi @asmit2952,

thanks for the image.

I can see some differences between your logo (red) and the reference image (black)

@jorgeamadosoria

asmitbm · 2021-11-08T09:23:59Z

hi @asmit2952,

thanks for the image.

I can see some differences between your logo (red) and the reference image (black)

@jorgeamadosoria

I'll fix that.

I checked that changes, but as per Contribution guidelines, the logo should be in the center in the viewbox, if I place it in the center, I get an error when I npm run lint...I get an error saying the SVG is not centered (11.56, 12) it should be (12, 12).
Actually 11.56 is correct position. So how do I eliminate that error?

dirien · 2021-11-08T09:28:58Z

@asmit2952, I am not a good designer myself, so maybe one of the @simple-icons/maintainers have a hint for you?

asmitbm · 2021-11-08T09:30:47Z

@asmit2952, I am not a good designer myself, so maybe one of the @simple-icons/maintainers have a hint for you?

Okay, I'll share the screenshot of the error

asmitbm · 2021-11-08T09:55:21Z

@dirien Can you check the icon now? I modified the SVG

sachinraja · 2021-12-17T01:11:31Z

I think this is considered misuse, we cannot use a flat color.

asmitbm · 2021-12-17T02:19:56Z

I think this is considered misuse, we cannot use a flat color.

Same is done for IBM Watson PR #4634 and Issue #3681 on this repository. The color is stated on their official website.

sachinraja · 2021-12-17T02:24:21Z

The color is stated on their official website

What color?

asmitbm · 2021-12-17T02:25:36Z

The color is stated on their official website

What color?

#08BDBA...the teal background

sachinraja · 2021-12-17T02:29:59Z

Yes, but it still does not have the gradient on the lines at the top.

asmitbm · 2021-12-17T02:32:54Z

And this is the official IBM Watson logo. @sachinraja

asmitbm · 2021-12-17T02:35:09Z

Yes, but it still does not have the gradient on the lines at the top.

Official Website Guidelines

sachinraja · 2021-12-17T02:37:20Z

I'm not sure about the other IBM icons that were added, but the gradient discussion was not brought up in those PRs. About the limited-use logo, I don't think SVG icons can be used for those purposes.

asmitbm · 2021-12-17T02:39:57Z

I'm not sure about the other IBM icons that were added, but the gradient discussion was not brought up in those PRs. About the limited-use logo, I don't think SVG icons can be used for those purposes.

There are no gradient logos on Simple Icons website as far as I have seen. Adding a gradient wouldn't simplify the SVG needed in single line, according to contribution.md

sachinraja · 2021-12-17T02:42:07Z

That's why I'm saying I don't think we can add this. We can wait to see what the other maintainers think though (mentioning @dirien and @jorgeamadosoria).

asmitbm · 2021-12-17T02:44:37Z

That's why I'm saying I don't think we can add this. We can wait to see what the other maintainers think though (mentioning @dirien and @jorgeamadosoria).

Okay👍🏻✌🏼

jorgeamadosoria · 2021-12-17T20:34:48Z

Icons in Simple Icons can't have gradients.
The limited use logo says "best for", not "exclusively for", so we are fine.
In this case converting the gradient into solid is the proper way to do it, unless there is a clause in IBM's guidelines that forbid tampering with the icon in this way. Given that they provide an icon for "limited-use" that is completely solid, this doesn't seem to be the case.

Finally, the icon should be centered in the 24x24 viewbox. If you have your icon centered and still see a discrepancy with the reference icon, it may be because the reference icon is not centered itself. try reducing its viewbox to 24x24 and centering the drawing, and then compare again.

Hope that helps.

sachinraja · 2021-12-17T21:20:27Z

The limited use logo says "best for", not "exclusively for", so we are fine.

It says "Please review all logo options to make sure this is the only logo appropriate for your needs." So I think anyone who needs an SVG version of this icon should use the gradient version from the website because it is not necessary that it be monochrome.

adamrusted · 2021-12-18T15:06:55Z

The limited use logo says "best for", not "exclusively for", so we are fine.

It says "Please review all logo options to make sure this is the only logo appropriate for your needs." So I think anyone who needs an SVG version of this icon should use the gradient version from the website because it is not necessary that it be monochrome.

Given we're a monochrome library, and a monochrome icon is available - we should include that variant, as well as a link to this page for guidelines. That way it is up to our users to decide which to use.

sachinraja · 2021-12-18T22:11:37Z

I disagree that "a monochrome icon is available" because they explicitly say not to use it if you don't have to, so I think it's more than just a variant.

asmitbm · 2022-03-05T12:44:30Z

Any updates on this PR? @dirien @sachinraja @jorgeamadosoria @adamrusted

jorgeamadosoria · 2022-03-05T19:49:13Z

IBMs Official

Checking the monochrome icon with gradient and the limited used one, I believe they are the same minus the gradient. And since the gradient needs to go away because the library does not allow for it, then it is functionally the same as taking the monochrome one and removing the gradients.
Given this, I'm fine with this proposal. We just need to correct the slight differences with the source and it should be fine.

@sachinraja if you. still have a problem with the color, we can switch the color of this icon to black, since that's also an acceptable color for the monochrome variant of the icon. It is not perfect, but it is an official variant and we are using it because we can't use anything else in that page due to the gradients. We checked, and that's the only version we can use, therefore we fulfilled their requisites.

I'm good with this. The only remaining concerns are whether we are going to keep teal or change to black as color, and whether @asmit2952 corrects the differences previously pointed out.

sachinraja · 2022-03-05T20:57:24Z

@jorgeamadosoria I'm fine with merging this given your comment. Although I think we should change it to the IBM blue brand color shown in #6746 (comment).

jorgeamadosoria · 2022-03-05T21:02:07Z

@jorgeamadosoria I'm fine with merging this given your comment. Although I think we should change it to the IBM blue brand color shown in #6746 (comment).

I think blue is far more representative for IBM too, yes.

@asmit2952 can you please change the color to IBM blue, and correct the slight differences? It seems we have reached an agreement now. When you do, please let us know to check and merge!

asmitbm · 2022-03-06T03:19:41Z

@jorgeamadosoria I'm fine with merging this given your comment. Although I think we should change it to the IBM blue brand color shown in #6746 (comment).

I think blue is far more representative for IBM too, yes.

@asmit2952 can you please change the color to IBM blue, and correct the slight differences? It seems we have reached an agreement now. When you do, please let us know to check and merge!

Sure, I'll change the color to IBM's blue, and other slight differences has been solved.

asmitbm · 2022-03-06T04:54:35Z

@jorgeamadosoria Updated the color

jorgeamadosoria · 2022-03-06T05:17:50Z

it's a perfect match with the limited use logo. LGTM

# New Icons - IBM Cloud (#6746) - PUBG (#7199)

Added IBM Cloud icon

2674fbc

Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com>

github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 18, 2021

service-paradis linked an issue Oct 18, 2021 that may be closed by this pull request

Request: IBM Cloud #6723

Closed

dirien self-requested a review November 5, 2021 22:02

dirien requested changes Nov 5, 2021

View reviewed changes

dirien requested changes Nov 8, 2021

View reviewed changes

modified svg

8453463

Changed color from teal to blue

0c65884

Merge branch 'develop' into ibmcloud-icon

9659648

jorgeamadosoria merged commit 121b43c into simple-icons:develop Mar 6, 2022

github-actions bot mentioned this pull request Mar 13, 2022

Publish 2 new icons #7212

Merged

mondeja added a commit that referenced this pull request Mar 13, 2022

Release 2 new icons (v6.14.0)

0c78227

# New Icons - IBM Cloud (#6746) - PUBG (#7199)

Add IBM Cloud icon #6746

Add IBM Cloud icon #6746

Conversation

asmitbm commented Oct 18, 2021 • edited Loading

Checklist

Description

dirien left a comment • edited Loading

Choose a reason for hiding this comment

asmitbm commented Nov 6, 2021

dirien commented Nov 7, 2021

asmitbm commented Nov 7, 2021

dirien commented Nov 8, 2021

asmitbm commented Nov 8, 2021 • edited Loading

dirien commented Nov 8, 2021

asmitbm commented Nov 8, 2021

dirien left a comment

Choose a reason for hiding this comment

asmitbm commented Nov 8, 2021

dirien commented Nov 8, 2021

asmitbm commented Nov 8, 2021

asmitbm commented Nov 8, 2021

sachinraja commented Dec 17, 2021

asmitbm commented Dec 17, 2021 • edited Loading

sachinraja commented Dec 17, 2021

asmitbm commented Dec 17, 2021 • edited Loading

sachinraja commented Dec 17, 2021

asmitbm commented Dec 17, 2021

asmitbm commented Dec 17, 2021

sachinraja commented Dec 17, 2021

asmitbm commented Dec 17, 2021

sachinraja commented Dec 17, 2021 • edited Loading

asmitbm commented Dec 17, 2021

jorgeamadosoria commented Dec 17, 2021

sachinraja commented Dec 17, 2021

adamrusted commented Dec 18, 2021

sachinraja commented Dec 18, 2021

asmitbm commented Mar 5, 2022

jorgeamadosoria commented Mar 5, 2022 • edited Loading

sachinraja commented Mar 5, 2022

jorgeamadosoria commented Mar 5, 2022

asmitbm commented Mar 6, 2022 • edited Loading

asmitbm commented Mar 6, 2022

jorgeamadosoria commented Mar 6, 2022

asmitbm commented Oct 18, 2021 •

edited

Loading

dirien left a comment •

edited

Loading

asmitbm commented Nov 8, 2021 •

edited

Loading

asmitbm commented Dec 17, 2021 •

edited

Loading

asmitbm commented Dec 17, 2021 •

edited

Loading

sachinraja commented Dec 17, 2021 •

edited

Loading

jorgeamadosoria commented Mar 5, 2022 •

edited

Loading

asmitbm commented Mar 6, 2022 •

edited

Loading