Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transifex icon #10133

Merged
merged 2 commits into from Dec 21, 2023
Merged

Conversation

lukasbestle
Copy link
Contributor

@lukasbestle lukasbestle commented Dec 16, 2023

transifex

Similarweb rank: 70,344

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The SVG is taken directly from their web app. The color is from the .u-fill-brand class in their stylesheet.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 16, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @lukasbestle, but I think we might need to go with the full wordmark here. The only other place I see them using just the "tx" is in their GH org where it has a different treatment, everywhere else they use the full logo. So I don't know that, outside the context of their own website, the "tx" can be considered recognisable as a branding element.

Also, on a sidenote having reviewed a couple of your PRs now: note that the brand colour isn't always necessarily the (primary) colour used in the source logo/icon. In this case, if I were taking it on myself and with a lack of any explicit guidelines on colour, I'd likely pick the grey from the logo or one of the most prevalent blue used on their website.

@lukasbestle
Copy link
Contributor Author

Thanks for your detailed reply.

I'm not sure about using the wordmark. Its aspect ratio is pretty non-square. Since this is Simple Icons and not Simple Logos, I thought the favicon would be a better fit for common use cases.

If you still think we should go with the wordmark, I'm happy to make the change. Same with the color.

@PeterShaggyNoble
Copy link
Member

Since this is Simple Icons and not Simple Logos

Oh, trust me, I'm fully in agreement with you on that one! 😆 Unfortunately, though, I seem to be in the minority and the precedent has been long since set. If we want to change it now then that's going to need to be separate discussion.

@lukasbestle
Copy link
Contributor Author

lukasbestle commented Dec 19, 2023

There are also other Simple Icons that use the square favicon instead of the very rectangular wordmark, for example Hetzner.

@PeterShaggyNoble
Copy link
Member

In the case of Hetzner, we received explicit permission from the company to use their favicon. See #6213 for more details.

@PeterShaggyNoble
Copy link
Member

Should have said in my last comment: if you'd like to reach out to Transifex to get their permission to use their favicon, too, that'd be great. If you do then it might be worth seeking clarification on the colour, too.

@lukasbestle
Copy link
Contributor Author

I checked their web app at https://app.transifex.com/contact/ again, which is what users of their service will get into contact with constantly (public contact page linked, the app itself requires logging in but uses the same layout and icon). I was able to pull the official SVG from there to replace the manually vectorized icon. Also I took their official brand color from the app stylesheet.

Is the prominent use in their web app enough or should I still double-check with them on whether we can use the "tx" icon?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, @lukasbestle; we can definitely run with the icon based on this. Everything looks perfect here now - thanks for the contribution.

@PeterShaggyNoble PeterShaggyNoble merged commit e2aab31 into simple-icons:develop Dec 21, 2023
3 checks passed
@lukasbestle lukasbestle deleted the feature/transifex branch December 21, 2023 11:08
@lukasbestle
Copy link
Contributor Author

@PeterShaggyNoble Thanks for merging my PRs and for your very helpful and constructive reviews. 👍

mondeja added a commit that referenced this pull request Dec 24, 2023
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants