Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Afterpay #10164

Merged
merged 6 commits into from Dec 21, 2023
Merged

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Dec 20, 2023

image

Sticker version:
image

Issue: closes #9771

Similarweb rank: ~1,4k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 20, 2023
@PeterShaggyNoble
Copy link
Member

We might have to go with the full logo, @service-paradis. This page states:

Our logo is made up of two elements: the Loop and the word Afterpay. They must always appear together and only in the colours specified.

Having said that, though, both the "Dos & Don'ts" and the brand guidelines confuse the issue by mentioning a "sticker" version with a circle background, so if we are going to run with just the icon then I think that's the version we should use. What do you reckon?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 20, 2023
@service-paradis
Copy link
Member Author

Their guidelines are not easy to follow!
They have examples with logo only as you said as Sticker or as App Icon:
image

You're right that, without wordmark, we probably need to use the sticker version. I will make the change!

@PeterShaggyNoble
Copy link
Member

Yeah, I had considered the "app" version as well but, as it appears that it's intended to represent the app only and we can't guarantee that that's what our users would use it for, I though the "sticker" version would be our safer option.

@service-paradis
Copy link
Member Author

Yeah, I had considered the "app" version as well but, as it appears that it's intended to represent the app only and we can't guarantee that that's what our users would use it for, I though the "sticker" version would be our safer option.

Just pushed the sticker version. I extracted directly the logo from the Brand Guidelines PDF.

@PeterShaggyNoble
Copy link
Member

@service-paradis, looks like you forgot to push the updated SVG.

@service-paradis
Copy link
Member Author

@service-paradis, looks like you forgot to push the updated SVG.

Done!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 👍🏻 Although there are a few excess points in the cut-out that could likely be removed, if you want to try before merging.

@service-paradis
Copy link
Member Author

Just removed some of them!

@PeterShaggyNoble PeterShaggyNoble merged commit fce4ac7 into simple-icons:develop Dec 21, 2023
3 checks passed
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 21, 2023
mondeja added a commit that referenced this pull request Dec 24, 2023
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
@service-paradis service-paradis deleted the add-afterpay branch January 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Afterpay icon
2 participants