Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transmission #9566

Merged
merged 7 commits into from Dec 20, 2023
Merged

Add transmission #9566

merged 7 commits into from Dec 20, 2023

Conversation

PratyushJayachandran
Copy link
Member

@PratyushJayachandran PratyushJayachandran commented Sep 16, 2023 •
edited by PeterShaggyNoble

transmission

Issue: closes #7490

Similarweb rank: 168,243. See https://www.similarweb.com/website/transmissionbt.com

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Vectorized from logo on front page https://transmissionbt.com/assets/images/Transmission_icon.png
Color: #D70008 Taken from the download button on the front page https://transmissionbt.com

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 16, 2023
@PeterShaggyNoble PeterShaggyNoble added the vector unavailable Issues and Pull Requests where no official SVG is available. label Nov 24, 2023
@PeterShaggyNoble
Copy link
Member

Looks pretty good to me, @PratyushJayachandran 👍🏻 But I think we should give the handle a bit more definition, either by adding cut-outs between each part or outlining the red part. What do you reckon?

@PratyushJayachandran PratyushJayachandran self-assigned this Nov 26, 2023
@PratyushJayachandran
Copy link
Member Author

Looks pretty good to me, @PratyushJayachandran 👍🏻 But I think we should give the handle a bit more definition, either by adding cut-outs between each part or outlining the red part. What do you reckon?

Done
transmission

PeterShaggyNoble
PeterShaggyNoble requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works much better, @PratyushJayachandran, nice work 👍🏻 Is it possible to get the handle to line up a bit better with the original, though?

_data/simple-icons.json Outdated
{
"title": "Transmission",
"hex": "D70008",
"source": "https://transmissionbt.com/assets/images/Transmission_icon.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to avoid potential future link rot, we should just run with the website for the source.

Suggested change
"source": "https://transmissionbt.com/assets/images/Transmission_icon.png"
"source": "https://transmissionbt.com"

@PratyushJayachandran
Copy link
Member Author

That works much better, @PratyushJayachandran, nice work 👍🏻 Is it possible to get the handle to line up a bit better with the original, though?

I started with a vectorized png and that seems to have resulted in my shapes being misaligned. Give me some time on this one.

@adamrusted
Copy link
Member

@PratyushJayachandran / @PeterShaggyNoble - there are SVGs available here or a monochrome (albeit tiny) icon here. Should we be using one of those as the source?

@PeterShaggyNoble
Copy link
Member

Nice find, @adamrusted! 👍🏻 I think the monochrome one is the one we should run with - what do you reckon, @PratyushJayachandran?

@PratyushJayachandran
Copy link
Member Author

Nice find, @adamrusted! 👍🏻 I think the monochrome one is the one we should run with - what do you reckon, @PratyushJayachandran?

That would be the easiest 🫣

@PratyushJayachandran
Copy link
Member Author

@PratyushJayachandran / @PeterShaggyNoble - there are SVGs available here or a monochrome (albeit tiny) icon here. Should we be using one of those as the source?

Changed to monochromatic icon which @adamrusted skillfully discovered.
transmission-v3

@PeterShaggyNoble PeterShaggyNoble merged commit fc9c9d0 into simple-icons:develop Dec 20, 2023
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Transmission branch December 20, 2023 15:22
@github-actions github-actions bot mentioned this pull request Dec 24, 2023
Merged
mondeja added a commit that referenced this pull request Dec 24, 2023
@mondeja
Release 21 new icons and 6 updated icons (v10.4.0)
f573581 
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees

@PratyushJayachandran PratyushJayachandran

Labels
new icon Issues or pull requests for adding a new icon vector unavailable Issues and Pull Requests where no official SVG is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transmission
3 participants
@PratyushJayachandran @PeterShaggyNoble @adamrusted