Add icon for 365 DataScience #10285
Merged
Add icon for 365 DataScience #10285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
PeterShaggyNoble
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Thanks for taking this one on, @BenHur28 👍🏻
However, much as I would personally prefer to run with just the icon, I think we are going to have to include the "365" as well - I can't find any examples of them using the icon on its own, outside of their favicon.
|
Hello @PeterShaggyNoble, I have added the "365" to the logo as you suggested. I also updated the initial preview image with a new preview image. |
PeterShaggyNoble
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks, @BenHur28, but the new version is vertically stretched; it should be 24dp in width, with the height remaining relative to that, preserving the aspect ratio.
|
Changed the 365DataScience.svg to have 24px width while maintaining proper height aspect ratio. Updated preview image with new svg preview image. |
PeterShaggyNoble
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks, @BenHur28. But I'm seeing some hairline differences when comparing against the logo in the website's header, most notably in
the top of the left circle (with yours in red). Most likely, that can be solved by increasing the precision by 1 when optimising. Would you mind having another look at it, please?
Also, you're missing a space in the name - see below.
_data/simple-icons.json
Outdated
| @@ -31,6 +31,11 @@ | |||
| "source": "https://1password.com/press", | |||
| "guidelines": "https://1password.com/press" | |||
| }, | |||
| { | |||
| "title": "365 DataScience", | |||
There was a problem hiding this comment.
Suggested change
| "title": "365 DataScience", | |
| "title": "365 Data Science", |
icons/365datascience.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>365 DataScience</title><path d="M1.5 13.647v-.858h.818c.575 0 1.183-.152 1.19-.668 0-.318-.258-.738-1.166-.738-.502 0-1.183.174-1.183.683H.09c0-1.2 1.216-1.633 2.26-1.633 1.07 0 2.221.509 2.23 1.692a1.172 1.172 0 0 1-.786 1.087c.542.175.924.7.924 1.168 0 1.36-1.305 1.758-2.399 1.758S.008 15.704 0 14.442h1.078c0 .572.786.77 1.248.77.542 0 1.264-.222 1.264-.818 0-.333-.187-.746-1.208-.746zm5.008-1.43v.833c.251-.376.866-.587 1.312-.587 1.144 0 2.343.468 2.343 1.85 0 1.233-1.207 1.844-2.35 1.844s-2.368-.611-2.368-1.858v-2.075c0-1.24 1.168-1.82 2.335-1.82 1.233 0 2.327.477 2.327 1.645H9.043c0-.492-.628-.738-1.24-.738-.64-.008-1.289.334-1.289.937zm2.593 2.096c0-.612-.567-.937-1.28-.937-.715 0-1.323.318-1.314.937.01.619.608.908 1.305.908.673 0 1.289-.297 1.289-.908zm5.997-2.812h-3.063v.977h1.1c1.209 0 2.287.485 2.279 1.787 0 1.263-1.078 1.867-2.221 1.867-1.247 0-2.317-.437-2.326-1.74h1.064c0 .613.713.77 1.248.77s1.174-.238 1.174-.897c.009-.628-.628-.81-1.216-.81H10.99v-2.94H15.1zm7.917-3.69a.95.95 0 0 0-.456 1.78l-1.925 4.72a.944.944 0 0 0-.8.082l-2.046-2.342a.943.943 0 0 0-.09-1.27.943.943 0 0 0-1.41 1.24.943.943 0 0 0 1.25.25l2.045 2.343a.952.952 0 0 0-.208.593.95.95 0 0 0 .266.693.95.95 0 0 0 1.57-.32.95.95 0 0 0 .062-.373.943.943 0 0 0-.343-.73l1.95-4.772a.826.826 0 0 0 .136.01.95.95 0 0 0 .908-.578.95.95 0 0 0-.214-1.054.95.95 0 0 0-.694-.266z"/></svg> | |||
There was a problem hiding this comment.
Suggested change
| <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>365 DataScience</title><path d="M1.5 13.647v-.858h.818c.575 0 1.183-.152 1.19-.668 0-.318-.258-.738-1.166-.738-.502 0-1.183.174-1.183.683H.09c0-1.2 1.216-1.633 2.26-1.633 1.07 0 2.221.509 2.23 1.692a1.172 1.172 0 0 1-.786 1.087c.542.175.924.7.924 1.168 0 1.36-1.305 1.758-2.399 1.758S.008 15.704 0 14.442h1.078c0 .572.786.77 1.248.77.542 0 1.264-.222 1.264-.818 0-.333-.187-.746-1.208-.746zm5.008-1.43v.833c.251-.376.866-.587 1.312-.587 1.144 0 2.343.468 2.343 1.85 0 1.233-1.207 1.844-2.35 1.844s-2.368-.611-2.368-1.858v-2.075c0-1.24 1.168-1.82 2.335-1.82 1.233 0 2.327.477 2.327 1.645H9.043c0-.492-.628-.738-1.24-.738-.64-.008-1.289.334-1.289.937zm2.593 2.096c0-.612-.567-.937-1.28-.937-.715 0-1.323.318-1.314.937.01.619.608.908 1.305.908.673 0 1.289-.297 1.289-.908zm5.997-2.812h-3.063v.977h1.1c1.209 0 2.287.485 2.279 1.787 0 1.263-1.078 1.867-2.221 1.867-1.247 0-2.317-.437-2.326-1.74h1.064c0 .613.713.77 1.248.77s1.174-.238 1.174-.897c.009-.628-.628-.81-1.216-.81H10.99v-2.94H15.1zm7.917-3.69a.95.95 0 0 0-.456 1.78l-1.925 4.72a.944.944 0 0 0-.8.082l-2.046-2.342a.943.943 0 0 0-.09-1.27.943.943 0 0 0-1.41 1.24.943.943 0 0 0 1.25.25l2.045 2.343a.952.952 0 0 0-.208.593.95.95 0 0 0 .266.693.95.95 0 0 0 1.57-.32.95.95 0 0 0 .062-.373.943.943 0 0 0-.343-.73l1.95-4.772a.826.826 0 0 0 .136.01.95.95 0 0 0 .908-.578.95.95 0 0 0-.214-1.054.95.95 0 0 0-.694-.266z"/></svg> | |
| <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>365 Data Science</title><path d="M1.5 13.647v-.858h.818c.575 0 1.183-.152 1.19-.668 0-.318-.258-.738-1.166-.738-.502 0-1.183.174-1.183.683H.09c0-1.2 1.216-1.633 2.26-1.633 1.07 0 2.221.509 2.23 1.692a1.172 1.172 0 0 1-.786 1.087c.542.175.924.7.924 1.168 0 1.36-1.305 1.758-2.399 1.758S.008 15.704 0 14.442h1.078c0 .572.786.77 1.248.77.542 0 1.264-.222 1.264-.818 0-.333-.187-.746-1.208-.746zm5.008-1.43v.833c.251-.376.866-.587 1.312-.587 1.144 0 2.343.468 2.343 1.85 0 1.233-1.207 1.844-2.35 1.844s-2.368-.611-2.368-1.858v-2.075c0-1.24 1.168-1.82 2.335-1.82 1.233 0 2.327.477 2.327 1.645H9.043c0-.492-.628-.738-1.24-.738-.64-.008-1.289.334-1.289.937zm2.593 2.096c0-.612-.567-.937-1.28-.937-.715 0-1.323.318-1.314.937.01.619.608.908 1.305.908.673 0 1.289-.297 1.289-.908zm5.997-2.812h-3.063v.977h1.1c1.209 0 2.287.485 2.279 1.787 0 1.263-1.078 1.867-2.221 1.867-1.247 0-2.317-.437-2.326-1.74h1.064c0 .613.713.77 1.248.77s1.174-.238 1.174-.897c.009-.628-.628-.81-1.216-.81H10.99v-2.94H15.1zm7.917-3.69a.95.95 0 0 0-.456 1.78l-1.925 4.72a.944.944 0 0 0-.8.082l-2.046-2.342a.943.943 0 0 0-.09-1.27.943.943 0 0 0-1.41 1.24.943.943 0 0 0 1.25.25l2.045 2.343a.952.952 0 0 0-.208.593.95.95 0 0 0 .266.693.95.95 0 0 0 1.57-.32.95.95 0 0 0 .062-.373.943.943 0 0 0-.343-.73l1.95-4.772a.826.826 0 0 0 .136.01.95.95 0 0 0 .908-.578.95.95 0 0 0-.214-1.054.95.95 0 0 0-.694-.266z"/></svg> |
…n by 1 on svg file.
…into 365-data-science
|
Increased the optimization precision by 1 and added space in between data and science as suggested. |
|
@BenHur28, it looks you may have forgotten to push the SVG with the updated, higher precision path here. |
|
Hello @PeterShaggyNoble, I've checked the 365datascience.svg files and it does appear to be the version of the file where I had increased the precision by 1. Please check again and worse case I can recreate the svg file once more if needed. |
|
🤔 Dunno what's happening here, @BenHur28, but it looks like something somewhere along the way is reducing the precision to 3 on you. I gave it a try myself and came up with the following path, if you'd like to run with it: |
|
Updated 365datascience.svg with newly suggested path in previous comment. |
PeterShaggyNoble
requested review from
service-paradis and
PratyushJayachandran
service-paradis
approved these changes
Jan 24, 2024
mondeja
added a commit
that referenced
this pull request
Jan 28, 2024
# New Icons - 365 Data Science (#10285) - Bluesound (#10337) - Eight (#10340) - File.io (#10338) - Glide (#10354) - htmx (#10301) - Iberia (#10346) - Indie Hackers (#10349) - Paperless-ngx (#10298) - Private Division (#10332) - Remedy Entertainment (#10331) - Rockwell Automation (#10341) - Rumahweb (#10334) - TOTVS (#10335) - ZCOOL (#10352) # Updated Icons - Hoppscotch (#10229) - Kongregate (#10318) - Private Internet Access (#10088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #10221
Similarweb rank: ~115k
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Took color from main webpage https://365datascience.com/