Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon: Paperless-ngx #10298

Merged
merged 12 commits into from
Jan 22, 2024
Merged

Add Icon: Paperless-ngx #10298

merged 12 commits into from
Jan 22, 2024

Conversation

TheRealGramdalf
Copy link
Contributor

Issue: closes #10287

Similarweb rank: 242,863

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Each step was made in a separate commit for easier review

  • Hex value was taken directly from original SVG
  • I was unable to find any license information regarding the original
  • Paperless-ngx is the official successor to both Paperless-ng and the original, Paperless; they were added as backwards compatible names

Preview:
paperlessngx

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 16, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @TheRealGramdalf 👍🏻 However, I'm seeing a couple of small differences that will need to be cleaned up, most notably in the cut-out of the left leaf. This could just be a precision issue.

Also, as both aliases are contained within the title there's no need to include them here.

_data/simple-icons.json Outdated Show resolved Hide resolved
@TheRealGramdalf
Copy link
Contributor Author

TheRealGramdalf commented Jan 17, 2024

Thanks for the contribution, @TheRealGramdalf 👍🏻 However, I'm seeing a couple of small differences that will need to be cleaned up, most notably in the cut-out of the left leaf. This could just be a precision issue.

The cut out is actually part of the official logo - it looks like it was originally intended for there to be a second notch in the larger leaf (there were two nodes that looked to be forming a notch that weren't colored correctly in the original).

Also, as both aliases are contained within the title there's no need to include them here.

This would still present issues with client libraries, no? I'm not familiar with the inner workings, but I don't think you can use part of a name to resolve it - i.e. if I specify the icon si-paperless in dashy (where si- is the simple icons slug), it wouldn't resolve to the PNGX logo unless paperless is listed as an alias

@PeterShaggyNoble
Copy link
Member

I wasn't suggesting removing the cut-out above, @TheRealGramdalf, simply using it to illustrate the small differences between your version (which is in red the image I linked and the source.

On the aliases: they're not used to retrieve icons; the old ones in particular are intended to be used for discoverability purposes. For example, to allow people to find icons on our website by searching for them by their old name.

@TheRealGramdalf
Copy link
Contributor Author

Got it. I believe the cutout mismatch is due to the stroke width - I removed that so there was a single path/fill. I'm not quite sure how to fix that precisely, I'm unfortunately not an SVG wizard (I primarily specialize in sysadmin).

@PeterShaggyNoble
Copy link
Member

I'm still seeing those same differences, @TheRealGramdalf. Your mention of a stroke, though, makes me wonder if you're not working from a different source file than the one you have in the JSON here, which doesn't have a stroke. So I gave it a try myself and came up with the following, if you'd like to run with it:

M6.338 23.028c-.117-.56-.353-1.678-.382-1.678-4.977-2.975-4.388-8.128-2.739-11.073.353 3.71 6.92 6.273 3.092 10.808-.03.059.177.765.353 1.413.766-1.296 1.915-2.856 1.856-3.004C3.806 8.01 18.53 7.126 21.592 0c1.385 6.89-.706 17.55-12.544 20.26-.06.03-2.15 3.71-2.238 3.74 0-.059-.884-.03-.766-.324.059-.177.177-.412.294-.648zm-.147-2.768c1.502-1.737-.265-4.712-1.325-5.683 1.796 3.092 1.679 4.888 1.325 5.683z

@TheRealGramdalf
Copy link
Contributor Author

I'm still seeing those same differences, @TheRealGramdalf.

Apologies if it wasn't clear - I'm not sure how to fix that myself (i.e. what values to tweak), since I don't do SVG work very often.

Your mention of a stroke, though, makes me wonder if you're not working from a different source file than the one you have in the JSON here, which doesn't have a stroke.

I'm referring to this: https://github.com/simple-icons/simple-icons/blob/36bdd3aabd2b699dc1b770f0a6c21a21ed597994/icons/paperlessngx.svg?short_path=0fec83c
It looks like exporting from inkscape to a plain SVG added the stroke value, which I guess is represented differently with the original inkscape version

So I gave it a try myself and came up with the following, if you'd like to run with it:

M6.338 23.028c-.117-.56-.353-1.678-.382-1.678-4.977-2.975-4.388-8.128-2.739-11.073.353 3.71 6.92 6.273 3.092 10.808-.03.059.177.765.353 1.413.766-1.296 1.915-2.856 1.856-3.004C3.806 8.01 18.53 7.126 21.592 0c1.385 6.89-.706 17.55-12.544 20.26-.06.03-2.15 3.71-2.238 3.74 0-.059-.884-.03-.766-.324.059-.177.177-.412.294-.648zm-.147-2.768c1.502-1.737-.265-4.712-1.325-5.683 1.796 3.092 1.679 4.888 1.325 5.683z

I gave it a look and that looks fine. I added the changes and rebased, so everything should be good to go.

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you @TheRealGramdalf and @PeterShaggyNoble!

@service-paradis service-paradis merged commit 2823225 into simple-icons:develop Jan 22, 2024
3 checks passed
mondeja added a commit that referenced this pull request Jan 28, 2024
# New Icons

- 365 Data Science (#10285)
- Bluesound (#10337)
- Eight (#10340)
- File.io (#10338)
- Glide (#10354)
- htmx (#10301)
- Iberia (#10346)
- Indie Hackers (#10349)
- Paperless-ngx (#10298)
- Private Division (#10332)
- Remedy Entertainment (#10331)
- Rockwell Automation (#10341)
- Rumahweb (#10334)
- TOTVS (#10335)
- ZCOOL (#10352)

# Updated Icons

- Hoppscotch (#10229)
- Kongregate (#10318)
- Private Internet Access (#10088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Paperless-ngx
3 participants