-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icon: Paperless-ngx #10298
Add Icon: Paperless-ngx #10298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @TheRealGramdalf 👍🏻 However, I'm seeing a couple of small differences that will need to be cleaned up, most notably in the cut-out of the left leaf. This could just be a precision issue.
Also, as both aliases are contained within the title
there's no need to include them here.
The cut out is actually part of the official logo - it looks like it was originally intended for there to be a second notch in the larger leaf (there were two nodes that looked to be forming a notch that weren't colored correctly in the original).
This would still present issues with client libraries, no? I'm not familiar with the inner workings, but I don't think you can use part of a name to resolve it - i.e. if I specify the icon |
I wasn't suggesting removing the cut-out above, @TheRealGramdalf, simply using it to illustrate the small differences between your version (which is in red the image I linked and the source. On the aliases: they're not used to retrieve icons; the |
Got it. I believe the cutout mismatch is due to the stroke width - I removed that so there was a single path/fill. I'm not quite sure how to fix that precisely, I'm unfortunately not an SVG wizard (I primarily specialize in sysadmin). |
Aliases are contained within the `title` already Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
I'm still seeing those same differences, @TheRealGramdalf. Your mention of a
|
Apologies if it wasn't clear - I'm not sure how to fix that myself (i.e. what values to tweak), since I don't do SVG work very often.
I'm referring to this: https://github.com/simple-icons/simple-icons/blob/36bdd3aabd2b699dc1b770f0a6c21a21ed597994/icons/paperlessngx.svg?short_path=0fec83c
I gave it a look and that looks fine. I added the changes and rebased, so everything should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you @TheRealGramdalf and @PeterShaggyNoble!
# New Icons - 365 Data Science (#10285) - Bluesound (#10337) - Eight (#10340) - File.io (#10338) - Glide (#10354) - htmx (#10301) - Iberia (#10346) - Indie Hackers (#10349) - Paperless-ngx (#10298) - Private Division (#10332) - Remedy Entertainment (#10331) - Rockwell Automation (#10341) - Rumahweb (#10334) - TOTVS (#10335) - ZCOOL (#10352) # Updated Icons - Hoppscotch (#10229) - Kongregate (#10318) - Private Internet Access (#10088)
Issue: closes #10287
Similarweb rank: 242,863
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Each step was made in a separate commit for easier review
Preview:
![paperlessngx](https://private-user-images.githubusercontent.com/79593869/297169476-523d4abc-8608-41dc-ba85-6fea0de995bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5MDAzODcsIm5iZiI6MTcyMzkwMDA4NywicGF0aCI6Ii83OTU5Mzg2OS8yOTcxNjk0NzYtNTIzZDRhYmMtODYwOC00MWRjLWJhODUtNmZlYTBkZTk5NWJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDEzMDgwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlYzliZTcxYmY4MDBkMjRmYTkyZjZkMDg0NDA1MThhOWNkZWIyY2FlMjhiNTViZTU1YTMzMGI2NTk2N2Q4NzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HARkF1gXVhsY51aymC0Mu8PKRUZXbFTSiYgmUmrKwT8)