Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rumahweb Icon #10334

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

Mvlprem
Copy link
Member

@Mvlprem Mvlprem commented Jan 21, 2024

rumahweb

Issue: closes #8824

Similarweb rank: 97,853

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

svg taken from website header, Hex taken from stylesheet --e-global-color-accent: #47CCFF

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 21, 2024
_data/simple-icons.json Outdated Show resolved Hide resolved
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the logo in the footer as the source here as it doesn't include the imperfections present in the one in the footer - would you mind updating the PR, please, @Mvlprem?

On the colour: my first instinct would have been to agree with your choice but, after seeing it referred to as an accent colour in their CSS variables, I think the shade used in that logo would be more accurate as the brand colour.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Mvlprem 👍🏻

@PeterShaggyNoble PeterShaggyNoble merged commit a9fa9e4 into simple-icons:develop Jan 23, 2024
3 checks passed
@Mvlprem Mvlprem deleted the Add-Rumahweb-Icon branch January 23, 2024 11:07
mondeja added a commit that referenced this pull request Jan 28, 2024
# New Icons

- 365 Data Science (#10285)
- Bluesound (#10337)
- Eight (#10340)
- File.io (#10338)
- Glide (#10354)
- htmx (#10301)
- Iberia (#10346)
- Indie Hackers (#10349)
- Paperless-ngx (#10298)
- Private Division (#10332)
- Remedy Entertainment (#10331)
- Rockwell Automation (#10341)
- Rumahweb (#10334)
- TOTVS (#10335)
- ZCOOL (#10352)

# Updated Icons

- Hoppscotch (#10229)
- Kongregate (#10318)
- Private Internet Access (#10088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] rumahweb.com
3 participants