-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexusmods #10313
Nexusmods #10313
Conversation
Thanks for taking this one on, @stefanobartoletti. And, wow, it's much trickier than it first looked! I didn't even notice the black background shape, which complicates things further. Had it been a basic shape, I would have said we could omit it but, as it follows the outline of the icon, I think you're right that we'll need to include it. I wonder could we simplify it a little bit by doing something like the following? What do you think? EDIT: Looking at your version again, we should probably have some separation where the arrows overlap themselves, as you do. |
Yep, that works much better, @stefanobartoletti - nicely done 👍🏻 I'm not entirely sure about the double border on the inner circle but as that's an entirely subjective opinion, I'll ask the other @simple-icons/maintainers what they think as well. If we do proceed with the current treatment as-is then I am seeing a few small differences, mostly around the outer edge and the insides of the arrows. Some of those could be accounted for by the fact that the source icon isn't a perfect square, though, while yours is. |
The icon looks not good on the badge. How about remove the white background part? |
While that would work much better for us, @LitoMore, unfortunately, if you look at the logo in the footer, their favicon and the logos on their social media sites, it definitely looks like the background shape is part of the icon and that we should therefore include it. |
how funny I come across this as soon as i need it. lookin good |
Thanks for your insights! :) @LitoMore the original icon has that border, as you can see also from their website favicon. @PeterShaggyNoble about small differences, maybe it can be accounted for having to clean the source svg, which really had a lot of unnecessary vertices, and to adapt a design that was intended to be displayed with multiple colors (so no need of borders) into a monochromatic icon. Most of the shapes had to be refined both before and after merging them into a single path, maybe this explains the small differences, together with optimization by SVGO (the linter complained and I had to test various precisions). Because of this, creating this icon was less easy than I thought, and at the moment I am unable to invest more time and effort into it. Especially because in its current state, it is both faithful enough to the source to be recognizable and identifiable at first glance and readable enough to be able to do these things also on small sizes (that is what matters the most). Unfortunately at the moment, I can't work on fixing pixel decimals for something that in the end won't even be noticeable. This does not mean that you should accept it if it is not up to your standards, just that I cannot personally do any more improvement. Feel free to use it as a base to further enhance it if this is what you need :) |
Gang, how about the below treatment?
EDIT: I realise I've just spent 20 minutes recreating the original PR, but I'd argue that's the best treatment for this icon. |
@adamrusted, yeah, that's where we started from in this PR. It looked a little busy at 24*24, though, which was what led to me suggesting a more simplified treatment. |
# New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@Garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@Garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)) # New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@Garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@Garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)
@adamrusted, did you mean to merge this one? It doesn't look like any changes were made since I mentioned that there were some differences that needed fixing. |
Issue: closes #10311
Similarweb rank:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description