Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Qbittorrent #9596

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Conversation

21st-centuryman
Copy link
Contributor

Issue: closes #8321

Similarweb rank:

18.9 k stars

https://github.com/qbittorrent/qBittorrent

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

qbittorrent

I believe the color I can use is the following: 2F67BA

It is used everywhere in the website:
https://www.qbittorrent.org/

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 19, 2023
@21st-centuryman 21st-centuryman changed the title Qbittorrent Add: Qbittorrent Sep 19, 2023
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@21st-centuryman Thank you for contributing. Please review the requested changes.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/qbittorrent.svg Show resolved Hide resolved
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some small differences in your version as well, @PratyushJayachandran (example from the "b", with yours in red) - might just need to up the precision 1 more.

@PratyushJayachandran
Copy link
Member

I'm seeing some small differences in your version as well, @PratyushJayachandran (example from the "b", with yours in red) - might just need to up the precision 1 more.

Please review once more. I increased the precision to 4.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran - I'm seeing tiny differences when comparing to this SVG. Did you use that to generate? Might need an even higher precision...
image

icons/qbittorrent.svg Outdated Show resolved Hide resolved
@PratyushJayachandran
Copy link
Member

@PratyushJayachandran - I'm seeing tiny differences when comparing to this SVG. Did you use that to generate? Might need an even higher precision...

I redid from source
Please check again @adamrusted

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran, I'm still seeing similar differences to Adam in the letters, and also in the circled - examples, with yours in red.

@PratyushJayachandran
Copy link
Member

@PratyushJayachandran, I'm still seeing similar differences to Adam in the letters, and also in the circled!

I redid and there was no diff. Please add code suggestion. Lets finish this PR.

@PeterShaggyNoble
Copy link
Member

OK, I think I see the problem here: The circle in the source SVG is so imperfect that it doesn't sit flush with the edges of the canvas.

And I'm guessing that that's having a knock on effect either in merging the 2 paths together, or in aligning the PR version with the source to get an accurate comparison, or both. And, in fact, when I centre the "qb" in the source independently from the circle then it lines up perfectly with the "qb" in your version.

From this other SVG, though, it's clear that the circle is supposed to be perfect. But, of course, the "qb" in that one isn't perfect! Why is it that the icons that should be the easiest are always the ones to give us the most hassle?!

So, my suggestion would be that we start with the original source, ditch the circle from it, recentre the "qb" and then draw our own perfect circle, resulting in the path below. What do you and the other @simple-icons/maintainers think? There'll obviously now be differences between our version and the source but I think ours would be more faithful to what its actually intende to be.

M 12 0A 12 12 0 0 0 0 12A 12 12 0 0 0 12 24A 12 12 0 0 0 24 12A 12 12 0 0 0 12 0zM 12 1.6738281A 10.327 10.327 0 0 1 22.326172 12A 10.327 10.327 0 0 1 12 22.326172A 10.327 10.327 0 0 1 1.6738281 12A 10.327 10.327 0 0 1 12 1.6738281zM 13.132812 3.7597656L 13.132812 16.658203L 14.478516 16.658203L 14.478516 15.488281C 15.053244 16.408847 15.845098 16.869141 16.855469 16.869141C 17.870636 16.869141 18.740992 16.432013 19.466797 15.558594C 20.191801 14.684376 20.554688 13.447106 20.554688 11.845703C 20.554687 11.171261 20.468734 10.537449 20.296875 9.9453125C 20.125015 9.3531774 19.886227 8.8479732 19.580078 8.4316406A 3.0119316 3.0110217 0 0 0 18.419922 7.4550781C 17.952306 7.2209411 17.455656 7.1035156 16.929688 7.1035156C 15.978468 7.1035156 15.196282 7.5222702 14.583984 8.3613281L 14.583984 3.7597656L 13.132812 3.7597656zM 7.0566406 7.1035156A 3.2565312 3.2555473 0 0 0 5.1855469 7.6835938C 4.6212099 8.065565 4.1892253 8.6282832 3.8886719 9.3730469C 3.5929146 10.118611 3.4453125 10.960291 3.4453125 11.898438C 3.4453125 13.441505 3.8104152 14.654811 4.5410156 15.541016C 5.2772116 16.426421 6.1528018 16.871094 7.1679688 16.871094A 2.5706932 2.5699166 0 0 0 8.4570312 16.527344C 8.865496 16.298001 9.1827882 16.010073 9.4082031 15.664062L 9.4082031 20.240234L 10.859375 20.240234L 10.859375 7.3144531L 9.5546875 7.3144531L 9.5546875 8.5644531C 8.947186 7.5911458 8.1141729 7.1035156 7.0566406 7.1035156zM 7.1933594 8.3535156C 7.8272392 8.3535156 8.3780868 8.6676262 8.8457031 9.2949219C 9.3181155 9.9230165 9.5546875 10.85736 9.5546875 12.101562C 9.5546875 13.268252 9.3307997 14.139489 8.8847656 14.714844C 8.4387316 15.283804 7.9069555 15.568359 7.2890625 15.568359C 6.6431924 15.568359 6.0917265 15.269248 5.6289062 14.669922C 5.1676847 14.066599 4.9355469 13.162788 4.9355469 11.960938C 4.9355469 10.723927 5.1530475 9.8133695 5.5878906 9.2324219C 6.0283292 8.6458806 6.5642756 8.3535156 7.1933594 8.3535156zM 16.798828 8.40625C 17.427912 8.40625 17.963858 8.6971952 18.404297 9.2773438C 18.849532 9.8582914 19.072266 10.759086 19.072266 11.978516C 19.072266 13.169178 18.840928 14.0658 18.378906 14.669922C 17.916886 15.26765 17.368254 15.568359 16.734375 15.568359C 15.955014 15.568359 15.337285 15.160787 14.880859 14.345703C 14.601089 13.846264 14.462891 13.036358 14.462891 11.916016C 14.462891 10.777294 14.692275 9.9118268 15.154297 9.3125C 15.617116 8.7083784 16.164949 8.40625 16.798828 8.40625z

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterShaggyNoble as you mentioned the circle is imperfect, so I borrowed it from the colored SVG. The result is below. Please check before accepting changes.

icons/qbittorrent.svg Outdated Show resolved Hide resolved
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with your suggested approach, @PratyushJayachandran. Given the original circle on the source icon is a mess I think we can get away with a minor difference for the sake of tidying it up!

Thanks for the work on this, both @21st-centuryman and @PratyushJayachandran!

@adamrusted adamrusted merged commit f5dbab9 into simple-icons:develop Feb 8, 2024
4 checks passed
mondeja added a commit that referenced this pull request Feb 11, 2024
# New Icons

- Actix (#9461) (@IamRezaMousavi)
- Appium (#10419) (@service-paradis)
- Better Stack (#10233) (@PeterShaggyNoble)
- Braintree (#10234) (@PeterShaggyNoble)
- Bungie (#10357) (@PeterShaggyNoble)
- Burp Suite (#10120) (@PeterShaggyNoble)
- Cloudron (#8085) (@simrahnb)
- Codefresh (#10327) (@PeterShaggyNoble)
- Excalidraw (#10241) (@PeterShaggyNoble)
- Formspree (#10385) (@service-paradis)
- Gojek (#10363) (@Mvlprem)
- Google Display & Video 360 (#10042) (@PratyushJayachandran)
- HiveMQ (#10393) (@jeoooo)
- Keenetic (#10275) (@PeterShaggyNoble)
- KNIME (#10370) (@BenHur28)
- Kununu (#10356) (@Mvlprem)
- LintCode (#10422) (@Mvlprem)
- Namu Wiki (#10328) (@PeterShaggyNoble)
- Neptune (#10316) (@PeterShaggyNoble)
- Nexus Mods (#10313) (@stefanobartoletti)
- Porkbun (#10247) (@PeterShaggyNoble)
- qbittorrent (#9596) (@21st-centuryman)
- Roll20 (#10425) (@Garbg)
- RustDesk (#10319) (@PeterShaggyNoble)
- Typst (#10399) (@Mvlprem)
- Western Union (#10383) (@Mvlprem)

# Updated Icons

- Accenture (#10424) (@Garbg)
- GitBook (#10390) (@service-paradis)
- Grammarly (#10416) (@adamrusted)
- Ruff (#10342) (@PeterShaggyNoble))

# New Icons

- Actix (#9461) (@IamRezaMousavi)
- Appium (#10419) (@service-paradis)
- Better Stack (#10233) (@PeterShaggyNoble)
- Braintree (#10234) (@PeterShaggyNoble)
- Bungie (#10357) (@PeterShaggyNoble)
- Burp Suite (#10120) (@PeterShaggyNoble)
- Cloudron (#8085) (@simrahnb)
- Codefresh (#10327) (@PeterShaggyNoble)
- Excalidraw (#10241) (@PeterShaggyNoble)
- Formspree (#10385) (@service-paradis)
- Gojek (#10363) (@Mvlprem)
- Google Display & Video 360 (#10042) (@PratyushJayachandran)
- HiveMQ (#10393) (@jeoooo)
- Keenetic (#10275) (@PeterShaggyNoble)
- KNIME (#10370) (@BenHur28)
- Kununu (#10356) (@Mvlprem)
- LintCode (#10422) (@Mvlprem)
- Namu Wiki (#10328) (@PeterShaggyNoble)
- Neptune (#10316) (@PeterShaggyNoble)
- Nexus Mods (#10313) (@stefanobartoletti)
- Porkbun (#10247) (@PeterShaggyNoble)
- qbittorrent (#9596) (@21st-centuryman)
- Roll20 (#10425) (@Garbg)
- RustDesk (#10319) (@PeterShaggyNoble)
- Typst (#10399) (@Mvlprem)
- Western Union (#10383) (@Mvlprem)

# Updated Icons

- Accenture (#10424) (@Garbg)
- GitBook (#10390) (@service-paradis)
- Grammarly (#10416) (@adamrusted)
- Ruff (#10342) (@PeterShaggyNoble)
@21st-centuryman 21st-centuryman deleted the qbittorrent branch February 11, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon: Qbittorent
4 participants