-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Qbittorrent #9596
Add: Qbittorrent #9596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@21st-centuryman Thank you for contributing. Please review the requested changes.
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing some small differences in your version as well, @PratyushJayachandran (example from the "b", with yours in red) - might just need to up the precision 1 more.
Please review once more. I increased the precision to 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratyushJayachandran - I'm seeing tiny differences when comparing to this SVG. Did you use that to generate? Might need an even higher precision...
I redid from source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratyushJayachandran, I'm still seeing similar differences to Adam in the letters, and also in the circled - , with yours in red.
I redid and there was no diff. Please add code suggestion. Lets finish this PR. |
OK, I think I see the problem here: The circle in the source SVG is so imperfect that it doesn't sit flush with the edges of the canvas. And I'm guessing that that's having a knock on effect either in merging the 2 paths together, or in aligning the PR version with the source to get an accurate comparison, or both. And, in fact, when I centre the "qb" in the source independently from the circle then it lines up perfectly with the "qb" in your version. From this other SVG, though, it's clear that the circle is supposed to be perfect. But, of course, the "qb" in that one isn't perfect! Why is it that the icons that should be the easiest are always the ones to give us the most hassle?! So, my suggestion would be that we start with the original source, ditch the circle from it, recentre the "qb" and then draw our own perfect circle, resulting in the path below. What do you and the other @simple-icons/maintainers think? There'll obviously now be differences between our version and the source but I think ours would be more faithful to what its actually intende to be.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterShaggyNoble as you mentioned the circle is imperfect, so I borrowed it from the colored SVG. The result is below. Please check before accepting changes.
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with your suggested approach, @PratyushJayachandran. Given the original circle on the source icon is a mess I think we can get away with a minor difference for the sake of tidying it up!
Thanks for the work on this, both @21st-centuryman and @PratyushJayachandran!
# New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@Garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@Garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)) # New Icons - Actix (#9461) (@IamRezaMousavi) - Appium (#10419) (@service-paradis) - Better Stack (#10233) (@PeterShaggyNoble) - Braintree (#10234) (@PeterShaggyNoble) - Bungie (#10357) (@PeterShaggyNoble) - Burp Suite (#10120) (@PeterShaggyNoble) - Cloudron (#8085) (@simrahnb) - Codefresh (#10327) (@PeterShaggyNoble) - Excalidraw (#10241) (@PeterShaggyNoble) - Formspree (#10385) (@service-paradis) - Gojek (#10363) (@Mvlprem) - Google Display & Video 360 (#10042) (@PratyushJayachandran) - HiveMQ (#10393) (@jeoooo) - Keenetic (#10275) (@PeterShaggyNoble) - KNIME (#10370) (@BenHur28) - Kununu (#10356) (@Mvlprem) - LintCode (#10422) (@Mvlprem) - Namu Wiki (#10328) (@PeterShaggyNoble) - Neptune (#10316) (@PeterShaggyNoble) - Nexus Mods (#10313) (@stefanobartoletti) - Porkbun (#10247) (@PeterShaggyNoble) - qbittorrent (#9596) (@21st-centuryman) - Roll20 (#10425) (@Garbg) - RustDesk (#10319) (@PeterShaggyNoble) - Typst (#10399) (@Mvlprem) - Western Union (#10383) (@Mvlprem) # Updated Icons - Accenture (#10424) (@Garbg) - GitBook (#10390) (@service-paradis) - Grammarly (#10416) (@adamrusted) - Ruff (#10342) (@PeterShaggyNoble)
Issue: closes #8321
Similarweb rank:
https://github.com/qbittorrent/qBittorrent
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I believe the color I can use is the following: 2F67BA
It is used everywhere in the website:
https://www.qbittorrent.org/