Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migadu icon #10561

Merged
merged 5 commits into from Mar 18, 2024
Merged

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Mar 3, 2024

preview image

Issue: closes #10498.

Similarweb rank: https://www.similarweb.com/website/migadu.com/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 3, 2024
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @uncenter!
Looking at both the source icon, and your PR there appear to be a lot of excess points, that we can probably clean up as part of this PR, mainly in the circular shapes.
image

Would you be up for having a go at that?

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Hmm I don't think I know my way around Inkscape well enough for that yet ahah.

@uncenter uncenter changed the title Add Migadu Add Migadu icon Mar 5, 2024
@PeterShaggyNoble PeterShaggyNoble self-assigned this Mar 15, 2024
@PeterShaggyNoble PeterShaggyNoble requested a review from a team March 15, 2024 14:04
@uncenter
Copy link
Member Author

Hmm but that removes the eye?

Screenshot 2024-03-15 at 10 04 24 (Arc)

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Mar 15, 2024

😮 The feck did that happen?!

Edit: Ah! I missed the fill-rule on the svg tag 🤦🏻‍♂️ Lemme grab a quick smoke and I'll get that fixed.

@uncenter
Copy link
Member Author

Not sure how to do that fancy overlay where you can see if it doesn't match up but from the naked eye the new SVG looks great!

@PeterShaggyNoble
Copy link
Member

Nothing fancy about it 😉 You just layer the PR version over the source (or vice versa) in contrasting colours.

@service-paradis
Copy link
Member

Nothing fancy about it 😉 You just layer the PR version over the source (or vice versa) in contrasting colours.

@PeterShaggyNoble Which source did you use?
I get some differences comparing with https://migadu.com/svg/logo_bg.svg. Ex.
image

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterShaggyNoble Nevermind, comparing to https://migadu.com/svg/logo.svg is a perfect match! Thank you @uncenter for your initial work on this!

@service-paradis service-paradis merged commit d8ce3b4 into simple-icons:develop Mar 18, 2024
3 checks passed
@uncenter uncenter deleted the feat/add-migadu branch March 20, 2024 13:03
mondeja added a commit that referenced this pull request Mar 24, 2024
# New Icons

- abuse.ch (#10551) (@Mvlprem)
- Anytype (#8941) (@RiteshK-611)
- Chess.com (#10670) (@uncenter)
- CorelDRAW (#10525) (@Mvlprem)
- CryptPad (#10213) (@PeterShaggyNoble)
- Dazhong Dianping (#10127) (@LitoMore)
- Decentraland (#10675) (@PeterShaggyNoble)
- fish shell (#10682) (@uncenter)
- G2G (#10657) (@PeterShaggyNoble)
- iMessage (#10676) (@uncenter)
- Inoreader (#10671) (@hjanaarthanan)
- Migadu (#10561) (@uncenter)
- Nushell (#10583) (@ApexDevelopment)
- Talos (#10666) (@buroa)
- thirdweb (#10672) (@PeterShaggyNoble)
- TV4 Play (#10677) (@PeterShaggyNoble)
- VitePress (#10674) (@PeterShaggyNoble)

# Updated Icons

- DataStax (#10549) (@Mvlprem)
- OSGeo (#10686) (@adamjstewart)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Migadu
4 participants