Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSGeo hex and guidelines #10686

Merged
merged 6 commits into from Mar 21, 2024

Conversation

adamjstewart
Copy link
Contributor

Very slight change in color, also added links to document the source.

Before

before

After

after

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamjstewart 👍🏻 Did you do a comparison between our current icon and the new source to make sure they line up perfectly? If so then just the one small change below and this is ready to merge.

_data/simple-icons.json Outdated Show resolved Hide resolved
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Mar 21, 2024
@adamjstewart
Copy link
Contributor Author

I did not compare the new and old source to make sure they're the same, I only updated the URL. I'm happy to undo that change if you want me to.

@PeterShaggyNoble
Copy link
Member

I noticed a lot of other guidelines use commit hashes for stability/reproducibility. Is this a new policy? I'm fine with whatever you decide.

Yeah, after looking at a few more entries, it seems we've become super-inconsistent about whether we use the default branch or the commit hash for the guidelines. We'll need to sort that out and address it. For this one, though, I've since found this page on their website, which I think would work better for the guidelines as it's more likely to be kept up to date with any future changes.

I did not compare the new and old source to make sure they're the same, I only updated the URL. I'm happy to undo that change if you want me to.

If we're not at least doing a comparison against the new source then, yes, we should keep our existing one.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamjstewart 👍

@PeterShaggyNoble PeterShaggyNoble merged commit 7a6ca4f into simple-icons:develop Mar 21, 2024
3 checks passed
@adamjstewart adamjstewart deleted the osgeo branch March 21, 2024 20:42
mondeja added a commit that referenced this pull request Mar 24, 2024
# New Icons

- abuse.ch (#10551) (@Mvlprem)
- Anytype (#8941) (@RiteshK-611)
- Chess.com (#10670) (@uncenter)
- CorelDRAW (#10525) (@Mvlprem)
- CryptPad (#10213) (@PeterShaggyNoble)
- Dazhong Dianping (#10127) (@LitoMore)
- Decentraland (#10675) (@PeterShaggyNoble)
- fish shell (#10682) (@uncenter)
- G2G (#10657) (@PeterShaggyNoble)
- iMessage (#10676) (@uncenter)
- Inoreader (#10671) (@hjanaarthanan)
- Migadu (#10561) (@uncenter)
- Nushell (#10583) (@ApexDevelopment)
- Talos (#10666) (@buroa)
- thirdweb (#10672) (@PeterShaggyNoble)
- TV4 Play (#10677) (@PeterShaggyNoble)
- VitePress (#10674) (@PeterShaggyNoble)

# Updated Icons

- DataStax (#10549) (@Mvlprem)
- OSGeo (#10686) (@adamjstewart)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants