Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3 icons #1620

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Add 3 icons #1620

merged 5 commits into from
Sep 10, 2019

Conversation

louis993546
Copy link
Contributor

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

birjj
birjj suggested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@birjj birjj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons and colors look good! Two of the names are a bit off though.

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@birjj birjj merged commit e2460ff into simple-icons:develop Sep 10, 2019
@birjj
Copy link
Contributor

birjj commented Sep 10, 2019

👍 Thanks for your work on this @louistsaitszho! It is much appreciated.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Sep 11, 2019
@ericcornelissen ericcornelissen mentioned this pull request Sep 22, 2019
Merged
birjj added a commit that referenced this pull request Sep 23, 2019
@birjj
Publish 1.16.0
884279e 
# New icons

- Nintendo 3DS (#1618)
- Zulip (#1618)
- CodeFactor (#1620)
- Showpad (#1620)
- Svelte (#1620)
- Expo (#1621)
- Zalando (#1630)
- Azure Artifacts (#1630)
- GNU Privacy Guard (#1632)


# Updated icons

- VK (#1618)
@devlead devlead mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

@birjj birjj birjj approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis993546 @birjj @ericcornelissen