Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expo icon #1621

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Sep 11, 2019

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're "working on Expo" @EvanBacon? Can you clarify?

I'm asking because the logo you added is not the one I would expect looking at the website, I would expect the SVG that is found in the header over there. Furthermore, I wasn't able to find (a version of) the SVG in this Pull Request in the link you specified.

That said, if you're part of the Expo team I trust your decisions and I'm happy to merge this as is 😉

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Sep 11, 2019
@EvanBacon
Copy link
Contributor Author

EvanBacon commented Sep 11, 2019

@ericcornelissen I appreciate your due diligence! It looks like I had pasted the wrong link. The logo is from the app icon, we've been transitioning to this new logo. The website is currently under redesign 😅

I ran this logo by 2 of the founders @brentvatne and @ide too.

@ericcornelissen ericcornelissen merged commit 96cd98c into simple-icons:develop Sep 13, 2019
@ericcornelissen
Copy link
Contributor

In that case, many thanks for the contribution @EvanBacon 🎉

The logo will be available on the website and package with the next release

@EvanBacon EvanBacon deleted the @evanbacon/expo branch September 15, 2019 07:41
birjj added a commit that referenced this pull request Sep 23, 2019
# New icons

- Nintendo 3DS (#1618)
- Zulip (#1618)
- CodeFactor (#1620)
- Showpad (#1620)
- Svelte (#1620)
- Expo (#1621)
- Zalando (#1630)
- Azure Artifacts (#1630)
- GNU Privacy Guard (#1632)


# Updated icons

- VK (#1618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants