Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GNU Privacy Guard #1632

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Add GNU Privacy Guard #1632

merged 1 commit into from
Sep 20, 2019

Conversation

casperdcl
Copy link
Contributor

Issue: #1631

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • hex value from original source SVG (below)

snapshot current

@casperdcl casperdcl mentioned this pull request Sep 19, 2019
Merged
@casperdcl
Copy link
Contributor Author

casperdcl commented Sep 19, 2019 •
edited
Loading

  • not sure if should abbreviate to "gnupg" rather than "GNU Privacy Guard"
  • not sure if should use favicon instead:

ericcornelissen
ericcornelissen approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Given your own concerns I will leave it for another maintainer to merge this or continue the discussion 😉

not sure if should abbreviate to "gnupg" rather than "GNU Provacy Guard"

The full version is better I think as it makes searching for the icon easier.

not sure if should use favicon instead

I personally don't think we should use that version.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Sep 20, 2019
@birjj birjj merged commit 67ae569 into simple-icons:develop Sep 20, 2019
@birjj
Copy link
Contributor

birjj commented Sep 20, 2019

👍 I agree with all choices taken so far in this PR. Thanks for your work on this @casperdcl!

@ericcornelissen ericcornelissen mentioned this pull request Sep 22, 2019
Merged
birjj added a commit that referenced this pull request Sep 23, 2019
@birjj
Publish 1.16.0
884279e 
# New icons

- Nintendo 3DS (#1618)
- Zulip (#1618)
- CodeFactor (#1620)
- Showpad (#1620)
- Svelte (#1620)
- Expo (#1621)
- Zalando (#1630)
- Azure Artifacts (#1630)
- GNU Privacy Guard (#1632)


# Updated icons

- VK (#1618)
@devlead devlead mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casperdcl @birjj @ericcornelissen