Add C# (#625)

[alisen]

Issue: #625

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

Description

I picked sourced from Wikipedia, made some certain types of changes in order to tasks.

[ericcornelissen]

Thank you for taking the time to contribute @alisen! The Pull Requests looks good overall, you're just missing a role="img" attribute on the <svg> tag 😉

That said, do you have any source (other then Wikipedia) that this round version is some sort of official version? Given the Google Image result for C# and the C++ logo we already have I would expect the "C#" to be inside a rounded hexagon 🤔 @simple-icons/maintainers, what are your opinions?

[alisen]

Thanks for pointing out the missing attribute. @ericcornelissen Actually, I take it from Wikipedia because on this site https://docs.microsoft.com/en-us/dotnet/ they are using the same version like Wikipedia.

[alisen]

@ericcornelissen I made the changes. Is there anything to else do it?

[ericcornelissen]

@alisen I'm just waiting for feedback from other @simple-icons/maintainers about the style of the logo (circle or hexagon), please be patient 🙂

[birjj]

@ericcornelissen When it comes to programming languages without official logos, I think we should defer to whatever the most authoritative source we can find is. In the case of C++, that was the Standard C++ Foundation (also used on Wikipedia). In the case of C#, I think that would be Microsoft themselves, who use the circle logo (also used on Wikipedia).

That being said, we'd definitely want the circle to be included. As the PR is now, the "C#" text is simply floating in the middle of the viewbox.

[phatbhoy67]

I agree with @birjolaxew, the wikipedia version links back to the dotnet docs so that is probably the right one to use, with the circle.

[ericcornelissen]

Thanks for the update @alisen, glad this is merged now 😃 Thanks a bunch for your work on this!

[alisen]

I'm glad we made it! @ericcornelissen 😃👾