Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Khan Academy Icon (#1882) #1884

Merged
merged 2 commits into from Nov 8, 2019

Conversation

bonez0607
Copy link
Contributor

Issue: #1882

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex Color: #0A2A66 - selected from page 6 of logo guideline presentation and usage suggestion for one color log from page 5.

Can update hex value to #14BF96 if needed.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Nov 5, 2019
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the logo @bonez0607 👍 The icon looks good to me, however I would say the brand colour should be #14BF96 rather than #0A2A66. Before you change that, what do the @simple-icons/maintainers think about the color?

@ericcornelissen ericcornelissen added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 5, 2019
@foo-dogsquared
Copy link
Contributor

The color #0A2A66 is used a lot in the website.
Though, I still think #14BF96 is the primary brand color to keep up with the previous "plant" logo motif.

@bonez0607
Copy link
Contributor Author

@foo-dogsquared and @ericcornelissen - I went ahead and updated the hex to #148F96 since you both are in agreement.

@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 8, 2019
@ericcornelissen ericcornelissen merged commit b2389ff into simple-icons:develop Nov 8, 2019
@ericcornelissen
Copy link
Contributor

Thanks for updating this icon @bonez0607, keeping the collection up-to-date is very important 😄

@ericcornelissen ericcornelissen added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed new icon Issues or pull requests for adding a new icon labels Nov 8, 2019
@ericcornelissen ericcornelissen changed the title Update Kahn Academy Icon (#1882) Update Khan Academy Icon (#1882) Nov 25, 2019
birjj added a commit that referenced this pull request Nov 25, 2019
New icons:

- AlliedModders (#1893)
- Bitrise (#1829)
- Khan Academy (#1884)
- C# (#1807)
- Mapbox (#1897)
- Monster (#1892)
- MicroStrategy (#1899)
- Pastebin (#1887)
- strongSwan (#1906)
- ABB RobotStudio (#1886)
- Asciidoctor (#1886)
- Source Engine (#1898)
- Valve (#1907)
- Steamworks (#1908)
- Apache NetBeans IDE (#1885)
- Beats by Dre (#1924)
- MDN Web Docs (#1925)
- Algolia (#1929)
- CodeChef (#1921)
- Minds (#1917)
- Duolingo ( #1922, 5388f8d)
- ManageIQ (#1926)
- ReactOS (#1941)
- IPFS (#1949)
- PureScript (#1910)
- PyUp (#1954)
- QEMU (#1957)
- Prometheus (#1964)
- Timescale (#1962)
- awesomeWM (#1966)
- Anchor (#1960)
- Zhihu (#1959)
- Google Search Console (#1947)
- InfluxDB (#1965)
- Apache OpenOffice (#1976)

Updated icons:

- Houzz (#1928)
- Vue.js (#1979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants