Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bitrise icon #1829

Merged
merged 8 commits into from Nov 8, 2019
Merged

Add Bitrise icon #1829

merged 8 commits into from Nov 8, 2019

Conversation

doomsayer13
Copy link
Contributor

@doomsayer13 doomsayer13 commented Oct 25, 2019 •
edited

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The SVG created/optimized by Dora Siraly Graphic designer of Bitrise.io

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 25, 2019
doomsayer13 and others added 4 commits October 25, 2019 15:35
@doomsayer13
Update bitrise.svg
c2fd916
@doomsayer13
Fix
ab9f406
@doomsayer13
Merge branch 'add-bitriseio-icon' of github.com:doomsayer13/simple-ic…
2f01d7f 
…ons into add-bitriseio-icon

* 'add-bitriseio-icon' of github.com:doomsayer13/simple-icons:
  Update bitrise.svg
@doomsayer13
Update bitrise.svg
c34fd1b
@phatbhoy67
Copy link
Contributor

Hey @doomsayer13 thanks for the contribution. 👍

Looking at the .svg file, the icon is not centered vertically within the viewbox.

Opening the .svg file in Inkscape, the width of the icon appears to be a fraction wider than 24px at 24.19px.

Can you check the width and make sure it is a maximum of 24px, and then center the icon both horizontally and vertically in the viewbox.

For reference, the contribution guidelines detail the steps necessary, including examples and a checklist prior to submission. Hope that helps.

@doomsayer13
Copy link
Contributor Author

@phatbhoy67 Thanks for reviewing it and replying.
We just updated the icon, so please if you have some free time take a look on it.
Thanks ;)

@phatbhoy67
Copy link
Contributor

Thanks for adding the requested changes and for your contribution @doomsayer13, the icon looks great! 👍 .

I've requested a review from @ericcornelissen and hopefully it will be merged soon.

Note: Alexa Rank: 53,584

ericcornelissen
ericcornelissen suggested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between the version in the Pull Request and the official logo is very minor (see below ⬇️) but it is definitely there. I think you may have optimized the logo a bit too much @doomsayer13. Could you update your Pull Request where you set the precision of SVGO(MG) to 3 instead of 1?

comparison

@doomsayer13
Copy link
Contributor Author

@ericcornelissen Thanks for replying and for your feedback.
We made the requested changes, pls review it again and if we have to do any other changes let us know ;)

@ericcornelissen
Copy link
Contributor

Thanks for the update @doomsayer13 👍 Can you (again) update the SVG so that it is vertically centred in the viewbox, the same request as before.

ericcornelissen
ericcornelissen approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated @doomsayer13, everything is looking good now 👍

@ericcornelissen ericcornelissen merged commit 827d5c0 into simple-icons:develop Nov 8, 2019
@ericcornelissen
Copy link
Contributor

Thanks for the contribution @doomsayer13, it is much appreciated! The icon will be available with our next release 🙂

@ericcornelissen ericcornelissen mentioned this pull request Nov 25, 2019
Merged
birjj added a commit that referenced this pull request Nov 25, 2019
@birjj
Publish version 1.20.0
a26b15e 
New icons:

- AlliedModders (#1893)
- Bitrise (#1829)
- Khan Academy (#1884)
- C# (#1807)
- Mapbox (#1897)
- Monster (#1892)
- MicroStrategy (#1899)
- Pastebin (#1887)
- strongSwan (#1906)
- ABB RobotStudio (#1886)
- Asciidoctor (#1886)
- Source Engine (#1898)
- Valve (#1907)
- Steamworks (#1908)
- Apache NetBeans IDE (#1885)
- Beats by Dre (#1924)
- MDN Web Docs (#1925)
- Algolia (#1929)
- CodeChef (#1921)
- Minds (#1917)
- Duolingo ( #1922, 5388f8d)
- ManageIQ (#1926)
- ReactOS (#1941)
- IPFS (#1949)
- PureScript (#1910)
- PyUp (#1954)
- QEMU (#1957)
- Prometheus (#1964)
- Timescale (#1962)
- awesomeWM (#1966)
- Anchor (#1960)
- Zhihu (#1959)
- Google Search Console (#1947)
- InfluxDB (#1965)
- Apache OpenOffice (#1976)

Updated icons:

- Houzz (#1928)
- Vue.js (#1979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doomsayer13 @phatbhoy67 @ericcornelissen @birjj