Update Tripadvisor #2510
Merged
Update Tripadvisor #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasJClark
force-pushed
the
tripadvisor2020
branch
from
7b2ef4e
to
79a148b
Compare
ericcornelissen
added
the
update icon/data
|
Thanks for your work on this, @ThomasJClark. Colour & source URL look good to me. Your SVG, however, is just a shade over 24px in width. |
ThomasJClark
force-pushed
the
tripadvisor2020
branch
from
79a148b
to
f0394da
Compare
|
I think the precision on svgo was a little too low, should be fixed now |
phatbhoy67
reviewed
Feb 2, 2020
phatbhoy67
previously requested changes
Feb 2, 2020
There was a problem hiding this comment.
Thanks for your work on this one @ThomasJClark 👍
The SVG and colour are good.
One little change before I merge this one in, can you please update the source to (https://tripadvisor.mediaroom.com/logo-guidelines) rather than the direct download link.
|
SVG looks good to me now, too, thanks for the update 👍 And I agree that @phatbhoy67's choice for the source URL would be more suitable. |
Co-Authored-By: phatbhoy67 <phatbhoy67@users.noreply.github.com>
ericcornelissen
approved these changes
Feb 13, 2020
|
Thanks for updating the Tripadvisor logo @ThomasJClark! Your contribution is much appreciated 😃 |
ericcornelissen
added a commit
that referenced
this pull request
Feb 17, 2020
# New icons - Google Tag Manager (#2195) - Untangle (#2524) - Dynamics 365 (#2523) - AdonisJS (#2540) - Android Studio (#2520) - Google My Business (#2521) - Alpine Linux (#2544) - Apache Solr (#2576) - YouTube Gaming (#2531) - Bugsnag (#2545) - Google Sheets (#2368) - KLM (#2588) - YouTube TV (#2480) - Pepsi (#2595) - Andela (#2599) - Pleroma (#2590) - Lighthouse (#2591) # Updated icons - Docker (#2561) - CodePen (#2045) - WhatsApp (#2581) - Kirby (#2578) - Reddit (#2580) - Kickstarter (#2577) - Quantopian (#2579) - Google Analytics (#2564) - Tripadvisor (#2510) - Microsoft Word (#2557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Update the Tripadvisor name (lowercase "a"), color, and logomark