Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamics 365 #2523

Merged
merged 2 commits into from Feb 6, 2020
Merged

Conversation

PeterShaggyNoble
Copy link
Member

Dynamics 365

Issue: Closes #2512

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

... Or Microsoft Dynamics 365?

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 4, 2020
@phatbhoy67
Copy link
Contributor

Hey @PeterShaggyNoble thanks for your work on this one and nice find on the .pdf btw 👏

When reviewing this I went to page 3 of the .pdf where the different size and colour icons are laid out.

From the "64 PX DYNAMICS 365 SYMBOL" section, I tried to match the PR version against the (almost) black version. It didn't match. I tried a few of the other versions on that page of different sizes to make sure and none of them matched. 🤔

I then isolated the icon from the layout image 👇 on page 2 and it matches the PR version, so now I am wondering which is the correct version of the icon we should be using? 😕
dyn365

@PeterShaggyNoble
Copy link
Member Author

I used the right-hand one from the page in your screenshot, @phatbhoy67. I'll try again with the 32px version on the next page, though, as it's closer to our native size. Or, alternatively, we could go with the Fabric Icons version (Dynamics365Logo)?

@phatbhoy67
Copy link
Contributor

phatbhoy67 commented Feb 6, 2020

Both versions in the layout page match your PR.

I might get my protractor out 📐 and measure that quoted 60 degree angle on the layout page to see if its an "artist's impression" of the icon. 🤣

AFAIK all the icons on page three are the same.

Update: the layout page angle does appear to measure "60 degrees", so all the icons on page 3 are off by about 3 degrees at rough guess............

LSS I am happy to merge this in as is @PeterShaggyNoble and thanks 👍

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit 32b493d into simple-icons:develop Feb 6, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the dynamics365 branch February 6, 2020 17:34
ericcornelissen added a commit that referenced this pull request Feb 17, 2020
# New icons

- Google Tag Manager (#2195)
- Untangle (#2524)
- Dynamics 365 (#2523)
- AdonisJS (#2540)
- Android Studio (#2520)
- Google My Business (#2521)
- Alpine Linux (#2544)
- Apache Solr (#2576)
- YouTube Gaming (#2531)
- Bugsnag (#2545)
- Google Sheets (#2368)
- KLM (#2588)
- YouTube TV (#2480)
- Pepsi (#2595)
- Andela (#2599)
- Pleroma (#2590)
- Lighthouse (#2591)

# Updated icons

- Docker (#2561)
- CodePen (#2045)
- WhatsApp (#2581)
- Kirby (#2578)
- Reddit (#2580)
- Kickstarter (#2577)
- Quantopian (#2579)
- Google Analytics (#2564)
- Tripadvisor (#2510)
- Microsoft Word (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamics 365
2 participants