Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lighthouse #2591

Merged
merged 1 commit into from Feb 16, 2020
Merged

Add Lighthouse #2591

merged 1 commit into from Feb 16, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Lighthouse

Issue: Closes #2585

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Lighthouse? Or Google Lighthouse?
  • #f44b21? Or #0535c1, from the full logo?

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 13, 2020
@muuvmuuv
Copy link

  1. Since it is by the Google team and lives in their repo I would prefix it with Google.
  2. blue seems to be more used but I like red more: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/report/html/report-styles.css#L38

What about

@ericcornelissen
Copy link
Contributor

Since it is by the Google team and lives in their repo I would prefix it with Google.

I would disagree. I think it is known as just "Lighthouse" and not "Google Lighthouse"

blue seems to be more used but I like red more: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/report/html/report-styles.css#L38

I think I agree with this, though both red and blue can work. I would prefer red as it is closer to the Lighthouse theme and more important in the logo.

@phatbhoy67
Copy link
Contributor

By red do you mean orange? 🍊

I can see #f4481e from full logo, and #f44b21 from favicon version (pr choice).

phatbhoy67
phatbhoy67 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svg is great @PeterShaggyNoble and I'm happy with your colour choice, but will leave it for another @simple-icons/maintainers to merge since there is debate about colour. 👍

@ericcornelissen ericcornelissen merged commit 4621bbb into simple-icons:develop Feb 16, 2020
@ericcornelissen
Copy link
Contributor

Thanks for the contribution @PeterShaggyNoble, it's appreciated as always 😃

Don't know what my confusion about the colour was about, but the one in the PR is actually fine by me 🙃

@ericcornelissen ericcornelissen mentioned this pull request Feb 16, 2020
Merged
@PeterShaggyNoble PeterShaggyNoble deleted the lighthouse branch February 17, 2020 10:55
ericcornelissen added a commit that referenced this pull request Feb 17, 2020
@ericcornelissen
Release 17 new icons and 10 updated icons (v2.5.0)
4e02525 
# New icons

- Google Tag Manager (#2195)
- Untangle (#2524)
- Dynamics 365 (#2523)
- AdonisJS (#2540)
- Android Studio (#2520)
- Google My Business (#2521)
- Alpine Linux (#2544)
- Apache Solr (#2576)
- YouTube Gaming (#2531)
- Bugsnag (#2545)
- Google Sheets (#2368)
- KLM (#2588)
- YouTube TV (#2480)
- Pepsi (#2595)
- Andela (#2599)
- Pleroma (#2590)
- Lighthouse (#2591)

# Updated icons

- Docker (#2561)
- CodePen (#2045)
- WhatsApp (#2581)
- Kirby (#2578)
- Reddit (#2580)
- Kickstarter (#2577)
- Quantopian (#2579)
- Google Analytics (#2564)
- Tripadvisor (#2510)
- Microsoft Word (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lighthouse icon
4 participants
@PeterShaggyNoble @muuvmuuv @ericcornelissen @phatbhoy67