-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio-technica #3018
Add audio-technica #3018
Conversation
Signed-off-by: Orchomenos <Finn.HB@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see you figured out how to create a Pull Requests @Orchomenos 👍
Your work looks pretty good already. There is just one thing that you will need to change, as you can see from your preview and the image below the logo does not fit the 24x24 viewbox exactly.
The extract the icon section of our guidelines should explain how to fix this. Essentially, you will need to make sure that you have a 24x24 pixels canvas in you editing software and then fit the logo in there. (if you need more help, feel free to ask us here and tell us what software you're using)
I thin I habe found my mistake. I am using Inkscape and there is a setting which is called something like scale for svg-user units per pixel, which I had on 2,6(standard setting) and now I put changed it to one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @Orchomenos, the SVG looks good now 👍
I'm just wondering if the title should be "Audio-Technica"
instead of "audio-technica"
(with capital letters). From my point of view, though I'm not familiar with the brand at all, the wordmark seems to use lowercase letters but in text the name is with capital letters. Look, for example, at the name in the website title or their social media pages.
So, could you updated the title in both the JSON file and the SVG 🙂 (or make a case for staying with all lowercase)
While I see where you are comming from, I used their packaging as help, because there it is written with smaller case letter... |
Well, it is not just there website but also their social media. As I pointed out, it seems to me that their wordmark logo uses lowercase letters and the brand name is with capitals. If you could, can you verify that the box does not contain a capitalized version of the name at all (e.g. on the back). Either way, I will ask for feedback from the other @simple-icons/maintainers on the issue to get some more input. |
I think the crucial part is that they write themselves "Audio-Technica" in the copyright part. So my vote goes there! :) |
I'd say it should be title case too. |
In that case, could you update the title in the JSON and SVG files @Orchomenos, thanks! |
Thanks for the update and thanks for the contribution @Orchomenos 🎉 It is very much appreciated! |
# New Icons - Badoo (#3004) - Bose (#3038) - Audio-Technica (#3018) - Apache CloudStack (#3023) - Open Badges (#2764) - Yoast (#2967) - OnePlus (#3007) - Awesome Lists (#3011) # Updated Icons - Adobe Acrobat Reader (#3029) - Roots (#3024) - Adobe After Effects (#3030) - Adobe Dreamweaver (#3030) - Adobe Audition (#3031) - Adobe Illustrator (#3033) - Adobe InDesign (#3033) - Adobe (#2769) - gulp (#2566)
Issue: Closes #3015
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Source for logo and colour is: https://upload.wikimedia.org/wikipedia/commons/b/b5/Audio-technica.svg, but I edited the logo so it is only contains the icon and fits the requirements.