Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio-technica #3018

Merged
merged 8 commits into from
May 6, 2020
Merged

Add audio-technica #3018

merged 8 commits into from
May 6, 2020

Conversation

finnkuhn
Copy link
Contributor

@finnkuhn finnkuhn commented May 1, 2020

audio-technica (2)

Issue: Closes #3015

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Source for logo and colour is: https://upload.wikimedia.org/wikipedia/commons/b/b5/Audio-technica.svg, but I edited the logo so it is only contains the icon and fits the requirements.

Signed-off-by: Orchomenos <Finn.HB@outlook.de>
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 2, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you figured out how to create a Pull Requests @Orchomenos 👍

Your work looks pretty good already. There is just one thing that you will need to change, as you can see from your preview and the image below the logo does not fit the 24x24 viewbox exactly.

The extract the icon section of our guidelines should explain how to fix this. Essentially, you will need to make sure that you have a 24x24 pixels canvas in you editing software and then fit the logo in there. (if you need more help, feel free to ask us here and tell us what software you're using)

audio

@finnkuhn
Copy link
Contributor Author

finnkuhn commented May 2, 2020

Glad to see you figured out how to create a Pull Requests @Orchomenos 👍

Your work looks pretty good already. There is just one thing that you will need to change, as you can see from your preview and the image below the logo does not fit the 24x24 viewbox exactly.

The extract the icon section of our guidelines should explain how to fix this. Essentially, you will need to make sure that you have a 24x24 pixels canvas in you editing software and then fit the logo in there. (if you need more help, feel free to ask us here and tell us what software you're using)

audio

I thin I habe found my mistake. I am using Inkscape and there is a setting which is called something like scale for svg-user units per pixel, which I had on 2,6(standard setting) and now I put changed it to one.
I also updated the preview image for this pull-request, so the icon is now displayed in the right size and with the right colour (#000000).

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Orchomenos, the SVG looks good now 👍

I'm just wondering if the title should be "Audio-Technica" instead of "audio-technica" (with capital letters). From my point of view, though I'm not familiar with the brand at all, the wordmark seems to use lowercase letters but in text the name is with capital letters. Look, for example, at the name in the website title or their social media pages.

So, could you updated the title in both the JSON file and the SVG 🙂 (or make a case for staying with all lowercase)

@finnkuhn
Copy link
Contributor Author

finnkuhn commented May 3, 2020

Nice job @Orchomenos, the SVG looks good now 👍

I'm just wondering if the title should be "Audio-Technica" instead of "audio-technica" (with capital letters). From my point of view, though I'm not familiar with the brand at all, the wordmark seems to use lowercase letters but in text the name is with capital letters. Look, for example, at the name in the website title or their social media pages.

So, could you updated the title in both the JSON file and the SVG 🙂 (or make a case for staying with all lowercase)

audio-technica packaging

While I see where you are comming from, I used their packaging as help, because there it is written with smaller case letter...
What do you think is more representative of a company - their website or packaging?

@ericcornelissen
Copy link
Contributor

Well, it is not just there website but also their social media. As I pointed out, it seems to me that their wordmark logo uses lowercase letters and the brand name is with capitals.

If you could, can you verify that the box does not contain a capitalized version of the name at all (e.g. on the back).

Either way, I will ask for feedback from the other @simple-icons/maintainers on the issue to get some more input.

@ericcornelissen ericcornelissen added in discussion There is an ongoing discussion that should be finished before we can continue and removed changes requested labels May 3, 2020
@finnkuhn
Copy link
Contributor Author

finnkuhn commented May 3, 2020

IMG_20200503_202235

On my box they used it with capital letters when using their offical company name and with smaller case letters when referring to their website or brand as a whole, so now I am even more confused.

@runxel
Copy link
Member

runxel commented May 3, 2020

I think the crucial part is that they write themselves "Audio-Technica" in the copyright part. So my vote goes there! :)

@PeterShaggyNoble
Copy link
Member

I'd say it should be title case too.

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels May 5, 2020
@ericcornelissen
Copy link
Contributor

In that case, could you update the title in the JSON and SVG files @Orchomenos, thanks!

@ericcornelissen ericcornelissen merged commit e9b6ad2 into simple-icons:develop May 6, 2020
@ericcornelissen
Copy link
Contributor

Thanks for the update and thanks for the contribution @Orchomenos 🎉 It is very much appreciated!

ericcornelissen added a commit that referenced this pull request May 10, 2020
# New Icons

- Badoo (#3004)
- Bose (#3038)
- Audio-Technica (#3018)
- Apache CloudStack (#3023)
- Open Badges (#2764)
- Yoast (#2967)
- OnePlus (#3007)
- Awesome Lists (#3011)

# Updated Icons

- Adobe Acrobat Reader (#3029)
- Roots (#3024)
- Adobe After Effects (#3030)
- Adobe Dreamweaver (#3030)
- Adobe Audition (#3031)
- Adobe Illustrator (#3033)
- Adobe InDesign (#3033)
- Adobe (#2769)
- gulp (#2566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audio-technica logo request
4 participants