-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bose #3038
Add bose #3038
Conversation
Signed-off-by: Orchomenos <Finn.HB@outlook.de>
Thanks for this one, @Orchomenos 👍 Two little things before we can merge it in, though:
You'll also need to remove the Audio-Technica JSON entry and SVG from your branch. Rather than working directly on the |
Thanks for updating, @Orchomenos - everything looks good to me now. Just need to remove the Audio-Technica SVG and this one is ready to merge. |
A tip for the future @Orchomenos, as the Contributing Guidelines suggest you should ideally checkout to a different branch when contributing anything. If you're unfamiliar with git branches, I recommend looking into it if you like contributing. In short, it's a way to make multiple contributions in parallel completely separate from each other. So if you want to contribute two icons, you create two branches and you can open two Pull Requests! Feel free to ask for more info or pointers with more information if you're interested 🙂 |
Thank you for the help, definitly going to use it in the future (or at least try to use it). |
Thanks for your work on this one, @Orchomenos 👍 |
# New Icons - Badoo (#3004) - Bose (#3038) - Audio-Technica (#3018) - Apache CloudStack (#3023) - Open Badges (#2764) - Yoast (#2967) - OnePlus (#3007) - Awesome Lists (#3011) # Updated Icons - Adobe Acrobat Reader (#3029) - Roots (#3024) - Adobe After Effects (#3030) - Adobe Dreamweaver (#3030) - Adobe Audition (#3031) - Adobe Illustrator (#3033) - Adobe InDesign (#3033) - Adobe (#2769) - gulp (#2566)
Issue: Closes #3017
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description