Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bose #3038

Merged
merged 14 commits into from
May 7, 2020
Merged

Add bose #3038

merged 14 commits into from
May 7, 2020

Conversation

finnkuhn
Copy link
Contributor

@finnkuhn finnkuhn commented May 6, 2020

bose

Issue: Closes #3017

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 6, 2020
@finnkuhn finnkuhn mentioned this pull request May 6, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for this one, @Orchomenos 👍

Two little things before we can merge it in, though:

  1. The name should be capitalised as "Bose"
  2. The SVG path is coming in at 24.001 wide, rather than 24.

You'll also need to remove the Audio-Technica JSON entry and SVG from your branch. Rather than working directly on the develop branch of your fork, we generally recommend creating a new branch for each icon/PR in order to help keep thing separated.

@PeterShaggyNoble
Copy link
Member

Thanks for updating, @Orchomenos - everything looks good to me now. Just need to remove the Audio-Technica SVG and this one is ready to merge.

@ericcornelissen
Copy link
Contributor

Thanks for updating, @Orchomenos - everything looks good to me now. Just need to remove the Audio-Technica SVG and this one is ready to merge.

A tip for the future @Orchomenos, as the Contributing Guidelines suggest you should ideally checkout to a different branch when contributing anything. If you're unfamiliar with git branches, I recommend looking into it if you like contributing.

In short, it's a way to make multiple contributions in parallel completely separate from each other. So if you want to contribute two icons, you create two branches and you can open two Pull Requests!

Feel free to ask for more info or pointers with more information if you're interested 🙂

@finnkuhn
Copy link
Contributor Author

finnkuhn commented May 7, 2020

Thank you for the help, definitly going to use it in the future (or at least try to use it).

@PeterShaggyNoble
Copy link
Member

Thanks for your work on this one, @Orchomenos 👍

@PeterShaggyNoble PeterShaggyNoble merged commit 54a1869 into simple-icons:develop May 7, 2020
ericcornelissen added a commit that referenced this pull request May 10, 2020
# New Icons

- Badoo (#3004)
- Bose (#3038)
- Audio-Technica (#3018)
- Apache CloudStack (#3023)
- Open Badges (#2764)
- Yoast (#2967)
- OnePlus (#3007)
- Awesome Lists (#3011)

# Updated Icons

- Adobe Acrobat Reader (#3029)
- Roots (#3024)
- Adobe After Effects (#3030)
- Adobe Dreamweaver (#3030)
- Adobe Audition (#3031)
- Adobe Illustrator (#3033)
- Adobe InDesign (#3033)
- Adobe (#2769)
- gulp (#2566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bose logo request
3 participants