New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #3021 - Apache Cloudstack icon #3023
Added #3021 - Apache Cloudstack icon #3023
Conversation
Welcome to Simple Icons, @kshitishp and thanks for the contribution: A couple of things before this can be merged in, though:
|
Thanks, Peter.
I had used a tool to convert the .ai file to .svg (I don't have Adobe
Illustrator). That must have changed a few things.
I'm checking it as I write this mail and I'll update the PR with the
correct version.
Cheers!
…---
Kshitish Purohit <https://www.linkedin.com/in/kshitishpurohit/> / (91) 9899
382 887 <+919899382887>
Chief Product Officer @indiqus <http://www.indiqus.com>
// This email is only intended for its recipients. If your name, or your
email ID, is not present in the recipients' list, or if you feel you got
this email by mistake, please delete this message, including any and all
attachments, immediately. This email is confidential and should be treated
as such.
On Tue, May 5, 2020 at 4:21 PM Peter Noble ***@***.***> wrote:
Welcome to Simple Icons, @kshitishp <https://github.com/kshitishp> and
thanks for the contribution:
A couple of things before this can be merged in, though:
1. The name should be "Apache CloudStack" (uppercase S).
2. The path needs to be centred vertically on the canvas.
3. Using the *Apache CloudStack logo with "open source cloud
computing" tagline and the Cloud Monkey (.ai file)
<http://svn.apache.org/repos/asf/cloudstack/media/ai/apache_cloudstack_with_cloud_monkey.ai>*
from the source URL, I see a difference in the monkey's hand (see image
below, with your version in red). Did you perhaps use a different source
than that for your version?
4. Where did you source the colour from?
<https://user-images.githubusercontent.com/15157491/81058640-ba63e880-8ec6-11ea-8843-acf47c0ee181.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3023 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO35VQAMFNIPOBFC7Z3PXMDRP7VURANCNFSM4MZK2SCQ>
.
|
This comment has been minimized.
This comment has been minimized.
Thanks for the quick update, @kshitishp. The path looks spot on to me now but it still needs to be vertically centred. I agree with your choice of colour now but, as there are a couple of possible alternatives, we'll need on of the other @simple-icons/maintainers to weigh in to be sure. |
Thanks, Peter.
Regarding vertical alignment, I've moved the artwork by a partial-pixel
distance to match the exact centre. I hope this does the trick.
Cheers!
…---
Kshitish Purohit <https://www.linkedin.com/in/kshitishpurohit/> / (91) 9899
382 887 <+919899382887>
Chief Product Officer @indiqus <http://www.indiqus.com>
// This email is only intended for its recipients. If your name, or your
email ID, is not present in the recipients' list, or if you feel you got
this email by mistake, please delete this message, including any and all
attachments, immediately. This email is confidential and should be treated
as such.
On Tue, May 5, 2020 at 5:56 PM Peter Noble ***@***.***> wrote:
Thanks for the quick update, @kshitishp <https://github.com/kshitishp>.
The path looks spot on to me now but it still needs to be vertically
centred. I agree with your choice of colour now but, as there are a couple
of possible alternatives, we'll need on of the other
@simple-icons/maintainers
<https://github.com/orgs/simple-icons/teams/maintainers> to weigh in to
be sure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3023 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO35VQFLMWYBTCNHRLVAIJDRQAAXXANCNFSM4MZK2SCQ>
.
|
Looks perfect to me now. Thanks for your efforts, @kshitishp 👍 Once someone else confirms your choice of colour, this can be merged in. Incidentally, most editing software includes a way to align objects and paths to save you having to do it manually. In Inkscape, for example, "Align and Distribute" can be found at the end of the "Object" menu. |
Sounds good :)
You’re right about the automatic alignment options but most tools align objects to the whole pixel and not to partials. I guess it depends on what tool is/was being used - I use Sketch and, interestingly, it lets you distribute partially but not align partially. So an object of 24 x 19.36 pixels would get aligned on a 24x24 board with some decimals to spare.
Will wait for the colour to get green-lit.
Cheers!
Kshitish Purohit / (91) 9899 382 887
Chief Product Officer @indiqus
// This email is only intended for the recipients. If your name, or your email ID, is not present in the recipients’ list, or if you think you got this email by mistake, please delete this message immediately (including any and all attachments). This email is confidential and should be treated as such.
…On 5 May 2020, 6:29 PM +0530, Peter Noble ***@***.***>, wrote:
Looks perfect to me now. Thanks for your efforts, @kshitishp 👍 Once someone else confirms your choice of colour, this can be merged in.
Incidentally, most editing software includes a way to align objects and paths to save you having to do it manually. In Inkscape, for example, "Align and Distribute" can be found at the end of the "Object" menu.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the colour I would expect, and the SVG looks good. Thanks for the contribution @kshitishp, it is very much appreciated! 🎉
You’re right about the automatic alignment options but most tools align objects to the whole pixel and not to partials. I guess it depends on what tool is/was being used - I use Sketch and, interestingly, it lets you distribute partially but not align partially. So an object of 24 x 19.36 pixels would get aligned on a 24x24 board with some decimals to spare.
That is interesting, and not something we have considered before (as far as a I know) 🤔
# New Icons - Badoo (#3004) - Bose (#3038) - Audio-Technica (#3018) - Apache CloudStack (#3023) - Open Badges (#2764) - Yoast (#2967) - OnePlus (#3007) - Awesome Lists (#3011) # Updated Icons - Adobe Acrobat Reader (#3029) - Roots (#3024) - Adobe After Effects (#3030) - Adobe Dreamweaver (#3030) - Adobe Audition (#3031) - Adobe Illustrator (#3033) - Adobe InDesign (#3033) - Adobe (#2769) - gulp (#2566)
Issue: Closes #3021
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description