Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #3021 - Apache Cloudstack icon #3023

Merged

Conversation

kshitishp
Copy link
Contributor

@kshitishp kshitishp commented May 5, 2020

Apache Cloudstack

Issue: Closes #3021

Checklist

  • [ Y ] I updated the JSON data in _data/simple-icons.json
  • [ Y ] I optimized the icon with SVGO or SVGOMG
  • [ Y ] The SVG viewbox is 0 0 24 24

Description

  • Picked the official hex value.
  • Used the .ai file in the source URL for creating the .svg.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 5, 2020
@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @kshitishp and thanks for the contribution:

A couple of things before this can be merged in, though:

  1. The name should be "Apache CloudStack" (uppercase S).
  2. The path needs to be centred vertically on the canvas.
  3. Using the Apache CloudStack logo with "open source cloud computing" tagline and the Cloud Monkey (.ai file) from the source URL, I see a difference in the monkey's hand (see image below, with your version in red). Did you perhaps use a different source than that for your version?
  4. Where did you source the colour from?

@kshitishp
Copy link
Contributor Author

kshitishp commented May 5, 2020 via email

@PeterShaggyNoble

This comment has been minimized.

@PeterShaggyNoble
Copy link
Member

Thanks for the quick update, @kshitishp.

The path looks spot on to me now but it still needs to be vertically centred. I agree with your choice of colour now but, as there are a couple of possible alternatives, we'll need on of the other @simple-icons/maintainers to weigh in to be sure.

@kshitishp
Copy link
Contributor Author

kshitishp commented May 5, 2020 via email

@PeterShaggyNoble
Copy link
Member

Looks perfect to me now. Thanks for your efforts, @kshitishp 👍 Once someone else confirms your choice of colour, this can be merged in.

Incidentally, most editing software includes a way to align objects and paths to save you having to do it manually. In Inkscape, for example, "Align and Distribute" can be found at the end of the "Object" menu.

@kshitishp
Copy link
Contributor Author

kshitishp commented May 5, 2020 via email

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the colour I would expect, and the SVG looks good. Thanks for the contribution @kshitishp, it is very much appreciated! 🎉


You’re right about the automatic alignment options but most tools align objects to the whole pixel and not to partials. I guess it depends on what tool is/was being used - I use Sketch and, interestingly, it lets you distribute partially but not align partially. So an object of 24 x 19.36 pixels would get aligned on a 24x24 board with some decimals to spare.

That is interesting, and not something we have considered before (as far as a I know) 🤔

@ericcornelissen ericcornelissen merged commit 88305eb into simple-icons:develop May 5, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request May 6, 2020
17 tasks
ericcornelissen added a commit that referenced this pull request May 10, 2020
# New Icons

- Badoo (#3004)
- Bose (#3038)
- Audio-Technica (#3018)
- Apache CloudStack (#3023)
- Open Badges (#2764)
- Yoast (#2967)
- OnePlus (#3007)
- Awesome Lists (#3011)

# Updated Icons

- Adobe Acrobat Reader (#3029)
- Roots (#3024)
- Adobe After Effects (#3030)
- Adobe Dreamweaver (#3030)
- Adobe Audition (#3031)
- Adobe Illustrator (#3033)
- Adobe InDesign (#3033)
- Adobe (#2769)
- gulp (#2566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Apache Cloudstack
3 participants