Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solidity #4740

Merged
merged 3 commits into from
Jan 17, 2021
Merged

Add Solidity #4740

merged 3 commits into from
Jan 17, 2021

Conversation

loganmarchione
Copy link
Contributor

@loganmarchione loganmarchione commented Jan 12, 2021

solidity (1)

Issue: Fixes #3807
Alexa rank: 59,338

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@PeterShaggyNoble @fbernhart - I submitted the icon that is 2 solid shapes since it seemed to be the more common icon.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 12, 2021
@fbernhart
Copy link
Contributor

@loganmarchione Could you provide a preview of the icons you're adding, using https://petershaggynoble.github.io/MDI-Sandbox/simpleicons/preview/?

Thanks a lot! 😊

@loganmarchione

This comment has been minimized.

icons/solidity.svg Outdated Show resolved Hide resolved
@adamrusted adamrusted added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Jan 13, 2021
@adamrusted
Copy link
Member

Could another @simple-icons/maintainers take a look at this icon as I've worked on the path and compare it against the SVG at source, as opposed to the PNG with the gaps?

@fbernhart
Copy link
Contributor

The SVG looks great! 👍🏼

Are you ok with #363636 as color @PeterShaggyNoble and @adamrusted? If yes, this PR can be merged.

@adamrusted
Copy link
Member

adamrusted commented Jan 17, 2021

As the calculated midpoint I'm happy with #363636, so let's merge away!

@adamrusted adamrusted merged commit adfe5c6 into simple-icons:develop Jan 17, 2021
@loganmarchione loganmarchione deleted the solidity branch January 17, 2021 23:32
ericcornelissen added a commit that referenced this pull request Jan 24, 2021
# New Icons

- Acclaim (#4820)
- Alitalia (#4808)
- Amazon DynamoDB (#4780)
- Bookmeter (#4829)
- Cachet (#4822)
- Corsair (#4798)
- Crystal (#4779)
- Eagle (#4809)
- Foxtel (#4784)
- IBM Watson (#4634)
- Kongregate (#4733)
- Lydia (#4836)
- Namecheap (#4811)
- OPNSense (#4557)
- Solidity (#4740)
- Songoda (#4810)

# Updated Icons

- AliExpress (#4815)
- Alipay (#4815)
- Bing (#4758)
- Corona Engine (#2846)
- Corona Renderer (#2846)
- Delicious (#4499)
- Firebase (#2846)
- Firefox (#2846)
- GitHub (#2846)
- GitHub Actions (#2846)
- Gmail (#4470)
- Google Assistant (#4401)
- Google Calendar (#4522)
- Klook (#4724)
- LG (#2846)
- LGTM (#2846)
- Taobao (#4815)
- Toyota (#2846)
- Umbraco (#4795, #4794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Solidity Icon
4 participants