Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eagle #4809

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add Eagle #4809

merged 2 commits into from
Jan 21, 2021

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 19, 2021

Eagle

Issue: Closes #3248
Alexa rank: ~150k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon is from SVG in this Dropbox folder linked from the source footer, colour is from the website stylesheet.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 19, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a few differences between PR (red) and source (black) on this one. Any chance you could take another look @PeterShaggyNoble?

image

@PeterShaggyNoble
Copy link
Member Author

Thanks, @adamrusted; looks like they updated the source SVG since I originally downloaded it. All should be well know but I did have to fix some imperfections, mainly arising from the various paths used for the eagle not lining up.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on! Thanks @PeterShaggyNoble 🦅

@adamrusted adamrusted merged commit 2600803 into simple-icons:develop Jan 21, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the add/eagle branch January 21, 2021 10:03
ericcornelissen added a commit that referenced this pull request Jan 24, 2021
# New Icons

- Acclaim (#4820)
- Alitalia (#4808)
- Amazon DynamoDB (#4780)
- Bookmeter (#4829)
- Cachet (#4822)
- Corsair (#4798)
- Crystal (#4779)
- Eagle (#4809)
- Foxtel (#4784)
- IBM Watson (#4634)
- Kongregate (#4733)
- Lydia (#4836)
- Namecheap (#4811)
- OPNSense (#4557)
- Solidity (#4740)
- Songoda (#4810)

# Updated Icons

- AliExpress (#4815)
- Alipay (#4815)
- Bing (#4758)
- Corona Engine (#2846)
- Corona Renderer (#2846)
- Delicious (#4499)
- Firebase (#2846)
- Firefox (#2846)
- GitHub (#2846)
- GitHub Actions (#2846)
- Gmail (#4470)
- Google Assistant (#4401)
- Google Calendar (#4522)
- Klook (#4724)
- LG (#2846)
- LGTM (#2846)
- Taobao (#4815)
- Toyota (#2846)
- Umbraco (#4795, #4794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eagle Software
2 participants