Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bing #4758

Merged
merged 5 commits into from
Jan 17, 2021
Merged

Update Bing #4758

merged 5 commits into from
Jan 17, 2021

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Jan 13, 2021 •
edited

bing

Issue: Fixes #4745
Alexa rank: 35

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Updated source. Gaps of 0.5px between segments. Hex picked as estimated mid-point of gradient.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 13, 2021
@fbernhart
Copy link
Contributor

I like the monochrome treatment, but it seems like you've created some imperfections at the bottom of the right gap.
image
image

As well it seems like at the top of the right gap you've cut off a bit too much.
image

There are as well some points pretty close to each other that maybe could be simplified?

@adamrusted
Copy link
Member Author

@fbernhart try that - first version was done in Inkscape as an experiment, second done in Illustrator.

@fbernhart
Copy link
Contributor

The SVG looks amazing now! 👍🏼

Concerning the color: That's really difficult. The middle part of the logo has a linear gradient from #39D2FF to #104CF5. The mid-point would be #258FFA.

But that's just as valid or not valid as your approach. 😅

@adamrusted
Copy link
Member Author

The middle part of the logo has a linear gradient from #39D2FF to #104CF5. The mid-point would be #258FFA.

Let's go with your hex @fbernhart, as it's been generated by an algorithm as opposed to me eyeballing it. Will update that, and it's ready for review.

@fbernhart
Copy link
Contributor

Great! 👍🏼 LGTM

@fbernhart fbernhart merged commit 70af5c3 into simple-icons:develop Jan 17, 2021
@adamrusted adamrusted deleted the Update/Bing branch January 17, 2021 22:51
PeterShaggyNoble added a commit to PeterShaggyNoble/simple-icons that referenced this pull request Jan 18, 2021
@PeterShaggyNoble
Update MIcrosoft Bing
037e51c 
Per simple-icons#4758
@github-actions github-actions bot mentioned this pull request Jan 24, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 24, 2021
@ericcornelissen
Release 16 new icons and 19 updated icons (v4.8.0)
a399e6c 
# New Icons

- Acclaim (#4820)
- Alitalia (#4808)
- Amazon DynamoDB (#4780)
- Bookmeter (#4829)
- Cachet (#4822)
- Corsair (#4798)
- Crystal (#4779)
- Eagle (#4809)
- Foxtel (#4784)
- IBM Watson (#4634)
- Kongregate (#4733)
- Lydia (#4836)
- Namecheap (#4811)
- OPNSense (#4557)
- Solidity (#4740)
- Songoda (#4810)

# Updated Icons

- AliExpress (#4815)
- Alipay (#4815)
- Bing (#4758)
- Corona Engine (#2846)
- Corona Renderer (#2846)
- Delicious (#4499)
- Firebase (#2846)
- Firefox (#2846)
- GitHub (#2846)
- GitHub Actions (#2846)
- Gmail (#4470)
- Google Assistant (#4401)
- Google Calendar (#4522)
- Klook (#4724)
- LG (#2846)
- LGTM (#2846)
- Taobao (#4815)
- Toyota (#2846)
- Umbraco (#4795, #4794)
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Bing
2 participants
@adamrusted @fbernhart