Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chemex #4792

Merged
merged 7 commits into from Mar 17, 2022
Merged

Add Chemex #4792

merged 7 commits into from Mar 17, 2022

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 18, 2021

Chemex

Issue: Templarian/MaterialDesign#5088
Alexa rank: ~229k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon & colour from this PDF linked from the end of the source page. I went with just the "X", as seen in their favicon. They do have a press kit but, even with an account, it's inaccessible and there may well be something in there that requires us to use the full wordmark or the registered trademark symbol.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 18, 2021
@ericcornelissen
Copy link
Contributor

[...] that requires us to use the full wordmark or the registered trademark symbol.

I'd say we can get away with just using the "X", but I'm pretty sure we should include the registered trademark symbol - especially given the following line from our Contributing Guidelines:

If there is ambiguity about the conditions under which the symbol is required, it must be included if it is a registered trademark symbol (®) but not if is a trademark symbol (™).


(I did not review the SVG or JSON data)

@PeterShaggyNoble
Copy link
Member Author

I'd agree with that, @ericcornelissen as they even using it when referencing the name in text. However, looking back over things myself again, I do think we should go with the full wordmark as the only place I see them using the "X" by itself is in their favicon.

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Aug 13, 2021
@ericcornelissen
Copy link
Contributor

However, looking back over things myself again, I do think we should go with the full wordmark as the only place I see them using the "X" by itself is in their favicon.

I don't have any strong opinions in that regard. I think just the "X" would look better in our format but indeed it seems they only use that as the favicon.

@adamrusted
Copy link
Member

Returning to this, it looks like they use just the X on top of their boxes (see here for an example). It would need the registered trademark icon next to it though.

@jorgeamadosoria
Copy link
Contributor

chemex

Added the registered trademark to the icon as pointed out by @adamrusted.
took the icon from here: https://vtlogo.com/chemex-coffeemaker-vector-logo-svg/
not an official source, but the icon is identical to the official and is already an SVG, so I don't think it matters all that much.

IMO, this is ready for merging, but of course it needs a review.

@jorgeamadosoria jorgeamadosoria removed changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels Mar 16, 2022
@sachinraja
Copy link
Contributor

Great job finishing this up @jorgeamadosoria!

@sachinraja sachinraja merged commit cee4208 into simple-icons:develop Mar 17, 2022
mondeja added a commit that referenced this pull request Mar 20, 2022
# New Icons

- AWS Lambda (#6907)
- Chemex (#4792)
- ClickHouse (#6854)
- CoinMarketCap (#5205)
- Conventional Commits (#7200)
- CrateDB (#7237)
- Dask (#7210)
- DVC (#7221)
- GNOME Terminal (#5690)
- Grand Frais (#6490)
- K3s (#6851)
- Lens (#6853)
- Linkerd (#7230)
- Liquibase (#7232)
- Matter.js (#6508)
- ONLYOFFICE (#7192)
- OpenSearch (#7207)
- Poetry (#7223)
- Soundcharts (#7225)
- Stardock (#7205)
- Supermicro (#4659)

# Updated Icons

- Ajv (#6508)
- Alacritty (#6508)
- Amazon DynamoDB (#7233)
- Amazon Fire TV (#7233)
- Amazon Lumberyard (#7233)
- Amazon Pay (#7233)
- Amazon S3 (#7233)
- AMD (#7233)
- AWS Amplify (#7233)
- GitLab (#7234)
- GNOME (#5690)
- MobX (#7229)
@PeterShaggyNoble PeterShaggyNoble deleted the add/chemex branch November 17, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants