Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS lambda icon #6907

Merged
merged 10 commits into from Mar 18, 2022
Merged

AWS lambda icon #6907

merged 10 commits into from Mar 18, 2022

Conversation

adsingh14
Copy link
Contributor

@adsingh14 adsingh14 commented Nov 24, 2021

Issue: #6889
Alexa rank: 11

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Color used from official brand guidelines
Icon used '32-bit svg icon' as reference from this link
awslambda

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 24, 2021
@service-paradis service-paradis linked an issue Nov 24, 2021 that may be closed by this pull request
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adsingh14, I am not sure if we can make the stroke bigger.

Asking one ohter @simple-icons/maintainers for advice?

@adamrusted
Copy link
Member

I am not sure if we can make the stroke bigger.

I would say no, given the entire icon is the outline. We would be altering the core logo too much to just make it bolder.

@adsingh14
Copy link
Contributor Author

I am not sure if we can make the stroke bigger.

I would say no, given the entire icon is the outline. We would be altering the core logo too much to just make it bolder.

No worries, I will match the stroke-width and update this commit.

@LitoMore
Copy link
Member

LitoMore commented Dec 22, 2021

No worries, I will match the stroke-width and update this commit.

No. We should always respect their artwork. The generated SVG from PNG/JPG definitely has some differences. You should find out the AWS Lambda logo from here: https://aws.amazon.com/architecture/icons/

Next time please spend some time on search logos with simple words: https://www.google.com.hk/search?q=aws+lambda+logo

@adsingh14
Copy link
Contributor Author

adsingh14 commented Dec 22, 2021

No. We should always respect their artwork. The generated SVG from PNG/JPG definitely has some differences. You should find out the AWS Lambda logo from here: https://aws.amazon.com/architecture/icons/

Next time please spend some time on search logos with simple words: https://www.google.com.hk/search?q=aws+lambda+logo

I'm designer too and respect the official work. I kept this on hold for some reasons with keeping in mind that they'd ask to curate it. I was unable to find https://aws.amazon.com/architecture/icons back then.

Edit: Even their provided .ppt file contains the png image. I've found another icon library and found the exact icon. Will update shortly.

@adamrusted
Copy link
Member

Edit: Even their provided .ppt file contains the png image. I've found another icon library and found the exact icon. Will update shortly.

The 'Asset Pack' below contains SVG versions of all the icons. Please use those.

@LitoMore
Copy link
Member

I think we should drop its background and make the λ filled.

@simple-icons/maintainers What do you think?

@sachinraja
Copy link
Contributor

I agree, so I think we can move forward with that @adsingh14

@adsingh14
Copy link
Contributor Author

I agree, so I think we can move forward with that @adsingh14

What about official icon then if we invert the fill? There are other icons, eg. MSFT translator, Adobe's, etc. , which we used as it is.

@sachinraja
Copy link
Contributor

That's actually a fair point and on second thought, after reading through the presentation a bit more, I think it makes sense to keep the current icon (even though I think it looks better filled).

@LitoMore
Copy link
Member

I think we should drop its background and make the λ filled.

What I mean is to fill the stroke. Not to fill them all. Like this below:

CleanShot 2022-01-10 at 14 24 47@2x

@jorgeamadosoria
Copy link
Contributor

I think the icon as presented by @LitoMore will work just fine: no background and stroke filled only.

Background could work too, but just to move this along, I would go with Lito's version.

@adsingh14 adsingh14 requested a review from dirien February 8, 2022 14:17
@dirien dirien removed their request for review February 11, 2022 20:14
@dirien
Copy link
Member

dirien commented Feb 11, 2022

Hi @adsingh14 did you updated the logo with the feedback of @LitoMore?

@dirien dirien added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Feb 11, 2022
@adsingh14
Copy link
Contributor Author

adsingh14 commented Feb 12, 2022

Hi @adsingh14 did you updated the logo with the feedback of @LitoMore?

I updated this logo on the basis of sachinraja, jorgeamadosoria and LitoMore suggestion.

I've decided to keep it original like I mentioned (#6907 (comment)) but other members were not okay with the original icon.

@sachinraja
Copy link
Contributor

Are you sure you pushed your changes @adsingh14? I see the updated icon in the icon preview but I don't see any new commits.

@adsingh14 adsingh14 requested a review from dirien March 6, 2022 15:00
@dirien dirien removed their request for review March 7, 2022 17:45
@sachinraja
Copy link
Contributor

@adsingh14 did you see my comment above?

Copy link
Contributor

@sachinraja sachinraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Some differences here (I believe in stroke size)
I used this icon from the asset pack:
Res_AWS-Lambda_Lambda-Function_48_Dark
and removed the circle around it.

Copy link
Contributor

@sachinraja sachinraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind this icon matches with this (also from the asset pack):
Arch_AWS-Lambda_48

Good work on this, thanks for sticking with it!

@sachinraja sachinraja merged commit 0b0a219 into simple-icons:develop Mar 18, 2022
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 18, 2022
@adsingh14 adsingh14 deleted the aws-lambda branch March 18, 2022 15:28
mondeja added a commit that referenced this pull request Mar 20, 2022
# New Icons

- AWS Lambda (#6907)
- Chemex (#4792)
- ClickHouse (#6854)
- CoinMarketCap (#5205)
- Conventional Commits (#7200)
- CrateDB (#7237)
- Dask (#7210)
- DVC (#7221)
- GNOME Terminal (#5690)
- Grand Frais (#6490)
- K3s (#6851)
- Lens (#6853)
- Linkerd (#7230)
- Liquibase (#7232)
- Matter.js (#6508)
- ONLYOFFICE (#7192)
- OpenSearch (#7207)
- Poetry (#7223)
- Soundcharts (#7225)
- Stardock (#7205)
- Supermicro (#4659)

# Updated Icons

- Ajv (#6508)
- Alacritty (#6508)
- Amazon DynamoDB (#7233)
- Amazon Fire TV (#7233)
- Amazon Lumberyard (#7233)
- Amazon Pay (#7233)
- Amazon S3 (#7233)
- AMD (#7233)
- AWS Amplify (#7233)
- GitLab (#7234)
- GNOME (#5690)
- MobX (#7229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: AWS Lambda
6 participants